Switch to api.openstreetmap.org API host

[danieldegroot2]

Use api.openstreetmap.org/api/ -and HTTPS- instead of www.openstreetmap.org/api/*.

(Is: openstreetmap/operations#951)

[HarelM]

Thanks! Will oauth2 work? I see some comments there which I didn't understand...

[danieldegroot2]

I avoided changing the ones in AuthClient.cs, NonAuthClient.cs and anything else in other files.

I think NonAuthClient.cs is complementary to ClientsFactory.cs in that it does API calls without authentication.
In that case it can also be changed to the api. URL. Let me know if this is correct.

---

As for the other two, note api.openstreetmap.org API url currently can not do OAuth 2 handshake. See openstreetmap/operations#951 (comment)
You can split the www. base URL and api. API url. See osmlab/osm-auth#123 (comment)

See also osmlab/osm-auth#123 (comment) for another solution.

[HarelM]

Does the www end point still works?
If this is the case, I prefer to keep the current address until everything is solved and then migrate... Makes more sense to me, but I might be wrong.
@blackboxlogic what do you think?

[danieldegroot2]

Does the www end point still works?

There have been no changes to the functionality, so yes.

[blackboxlogic]

@HarelM @danieldegroot2

Pro: longer timeouts
Con: Oauth2 breaks with work-arounds
Am I understanding that right?

Feel free to change all the documentation/comments, including in AuthClient.cs and NonAuthClient.cs to nudge users in the right direction. But updating PRODUCTION_URL is a breaking change I wouldn't surprise on users.

Maybe we should deprecate PRODUCTION_URL with a lengthy comment mentioning timeouts, Oath2, and the updated URL. Or, if there are plans to resolve the Oauth2 issue (are there?), then let's just wait for that to be resolved.

[danieldegroot2]

Pro: longer timeouts

Yes, though they are subject to change.

Con: Oauth2 breaks with work-arounds

Yes, without workarounds it would break, so to be safe you should use a workaround.

plans to resolve the Oauth2 issue

No timeline has been announced, so no.

then let's just wait for that to be resolved.

I will close this PR in favour of #9 .