Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows - Crash when having download dialogue #925

Closed
ghost opened this issue Aug 30, 2015 · 10 comments
Closed

Windows - Crash when having download dialogue #925

ghost opened this issue Aug 30, 2015 · 10 comments

Comments

@ghost
Copy link

@ghost ghost commented Aug 30, 2015

Tried to download a file from Dropbox, download dialogue appeared where i can pick the application to open the file and save it, dropdown arrow click for chosing the application triggered an instant crash, same like just trying to save the file.

Error message is this i found in the event manager:

Faulting application Name: otter-browser.exe Version: 0.9.0.7, time stamp: 0x55dd57fb
Name of the faulty module: Qt5Widgets.dll Version: 5.5.0.0, time stamp: 0x55912083
Exception code: 0xc0000005
Fault offset: 0x00000000002a306c
ID of the faulty process: 0x1b48
Start time of the faulting application: 0x01d0e358501d56b2
Path of the faulty application: C:\Users\SaphirJD\Desktop\Otter\otter-browser.exe
Path of the faulty module: C:\Users\SaphirJD\Desktop\Otter\Qt5Widgets.dll
Report ID: 9dca974a-4f4b-11e5-8482-bdf40ab1bd6c

@ghost
Copy link
Author

@ghost ghost commented Aug 30, 2015

What does work are the 2 right mouse context menu entries save to downloads and save link target as.

Crashes appear on both Win8 and Win7 64 bit

@Arandhras
Copy link

@Arandhras Arandhras commented Aug 30, 2015

I have the same issue, left-clicking any web link to a file triggers a browser crash.

@VSHY
Copy link

@VSHY VSHY commented Sep 9, 2015

I had a crash in beta 7 and build 88 when I tried to download otter-browser-win32-weekly88.zip.

@Emdek Emdek added this to the Beta 8 milestone Sep 25, 2015
@ghost
Copy link
Author

@ghost ghost commented Sep 30, 2015

Seems fixed.

Can anyone else confirm?

Otter 0.9.08 Weekly 91
Windows 7 64bit

@VSHY
Copy link

@VSHY VSHY commented Oct 1, 2015

@Emdek
Try to download otter-browser-win32-weekly91.zip:

  1. A temporary file are downloading to profile dir (c:\Users{user}\AppData\Local\Temp); it don't use Paths/Downloads setting.
  2. If to click on Save button then empty FileSave dialog appears; try to click the Save button, - sametimes this leads to a crash (it reminds #701).
    I used weekly91 with QtWebKit.
@Emdek
Copy link
Member

@Emdek Emdek commented Oct 1, 2015

@VSHY, that temporary file was always there (we need some buffer to store data before user decides what to do with download), but save dialog crash most likely caused auto deletion or was occurring too early to even create it.

Could you please post screenshot of that empty file dialog?
I'm getting instant crash after clicking Save in TransferDialog under Windows 7 32 bit (but works fine with Windows 10 64 bit).

BTW, it's possible to configure downloads using handlers.ini so this dialog won't show at all and won't create temporary files.
I'll add UI for that soon after releasing v2.

@VSHY
Copy link

@VSHY VSHY commented Oct 1, 2015

Dropbox.
Upload to Dropbox some photos. Exit from Dropbox.
Open url with photos.
Click "Download -> Download as .zip" and close dialog "Create Account", as result - processor is busy on 25%, nothing happens. Click button Stop in browser.
Click "Download -> Download as .zip" anew, click Save button in Download dialog, as result - crash.

@VSHY
Copy link

@VSHY VSHY commented Oct 1, 2015

@Emdek

Could you please post screenshot of that empty file dialog?
I'm getting instant crash after clicking Save in TransferDialog under Windows 7 32 bit

Now I have the same result on that environment and I can't reproduce the empty FileSave dialog, sorry. Maybe later.

@uahim
Copy link

@uahim uahim commented Oct 1, 2015

91 crashes on Win XP, the dialog opens and the file is being downloaded completely/to 100% (to a temporary directory I guess), and when you click e.g. "save", the file save dialog opens for less than a second - and Otter dies

@Emdek Emdek closed this in 9856a83 Oct 2, 2015
@Emdek
Copy link
Member

@Emdek Emdek commented Oct 2, 2015

@VSHY, @uahim, Save crash should be fixed now (at least I can no longer reproduce it using Windows 7 VM where it was almost 100% reproducible), although use of combobox still causes crash due to upstream issue (use of -style fusion command line switch might help in this case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.