Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests went from passing to failing with no code change #70

Closed
gully opened this issue Nov 22, 2021 · 2 comments
Closed

Tests went from passing to failing with no code change #70

gully opened this issue Nov 22, 2021 · 2 comments

Comments

@gully
Copy link
Member

gully commented Nov 22, 2021

The most recent commit failed, despite the only change being a tutorial. How could that happen? I am investigating! My first guess would be a dependency change, but we have a matrix of astropy/specutils/python dependencies that all went from passing to failing. It's not numpy because that was the same between the two passing and failing commits. Strange!

@gully
Copy link
Member Author

gully commented Nov 22, 2021

Something appears to have broken with astropy units between commit 3221bcf and the current HEAD. A workaround for @joelburke02 was to checkout this older commit.

@gully
Copy link
Member Author

gully commented Nov 23, 2021

Ah-ha! I have found the problem. The upstream dependency gwcs caused a breaking change between version 0.16 and 0.17. The problem was identified in this astropy issue:
astropy/specutils#898

As a workaround I have pinned the gwcs dependency, and in the process also pinned the ndcube dependency. We'll want to revisit these choices as the upstreams get changed. Closing for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant