New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump native API Server config on boot #338

Merged
merged 4 commits into from Dec 30, 2018

Conversation

2 participants
@voicevon
Copy link
Contributor

voicevon commented Dec 28, 2018

No description provided.

@@ -54,7 +54,7 @@ void APIServer::loop() {
}
}
void APIServer::dump_config() {

ESP_LOGI(TAG,"API Server:");

This comment has been minimized.

@OttoWinter

OttoWinter Dec 28, 2018

Owner

This is not an info message, it's a config message.
Space missing after comma.

This comment has been minimized.

@voicevon

voicevon Dec 28, 2018

Contributor

sure, I will use ESP_LOGCONFIG().Thanks.

voicevon and others added some commits Dec 28, 2018

@OttoWinter OttoWinter changed the title Api server dump_config() should not be empty Dump native API Server config on boot Dec 30, 2018

@OttoWinter OttoWinter merged commit db3d520 into OttoWinter:dev Dec 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@voicevon voicevon deleted the voicevon:api_server branch Dec 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment