Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weighted arrays in ensemble statistics #1151

Merged
merged 14 commits into from Aug 24, 2022
Merged

Weighted arrays in ensemble statistics #1151

merged 14 commits into from Aug 24, 2022

Conversation

RondeauG
Copy link
Contributor

@RondeauG RondeauG commented Aug 16, 2022

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added
  • The relevant author information has been added to .zenodo.json

What kind of change does this PR introduce?

  • weights argument added to ensembles.ensemble_percentiles, ensembles.ensemble_mean_std_max_min & ensembles.change_significance

Does this PR introduce a breaking change?

DataArrayWeighted.quantile() requires the latest xarray release (v.2022.06.0)

Other information:

@coveralls
Copy link

coveralls commented Aug 16, 2022

Coverage Status

Coverage decreased (-0.005%) to 91.38% when pulling 391d2da on ens-weights into 768538f on master.

Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and doesn't seem to interfere much with the non-weighted version.

However, if a specific xarray version is needed, we need to update the requirements.

xclim/ensembles/_base.py Outdated Show resolved Hide resolved
xclim/ensembles/_base.py Outdated Show resolved Hide resolved
xclim/ensembles/_base.py Outdated Show resolved Hide resolved
xclim/ensembles/_base.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, but this looks good to go!

HISTORY.rst Outdated Show resolved Hide resolved
environment.yml Show resolved Hide resolved
RondeauG and others added 2 commits August 24, 2022 16:45
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
@RondeauG RondeauG merged commit 1927f04 into master Aug 24, 2022
@RondeauG RondeauG deleted the ens-weights branch August 24, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants