Workflow security fixes - #2023
Merged
Merged
Conversation
…sting access tokens across steps
|
Note It appears that this Pull Request modifies the On inspection, the No further action is required. |
aulemahal
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
runstepsbump-my-versionlogicDoes this PR introduce a breaking change?
It should not.
Other information:
Changes suggested here were determined from analysis using https://github.com/woodruffw/zizmor
There are a handful of workflows that require
pull_request_targettriggers. This is insecure since it runs actions in the parent repo that can be influenced by configurations stemming from forks. The only way to fully secure this would be to try using reusable workflows. This would be a medium-effort task, with gains across all Ouranos repositories.