Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

remove RMMapBoxSource & RMMBTilesSource? #92

Closed
incanus opened this Issue Jul 26, 2012 · 3 comments

Comments

Projects
None yet
3 participants

incanus commented Jul 26, 2012

I don't feel super-strongly about this, but would you be open to the idea of removing these sources from your version? The reason I ask is because beyond the extra things that we're doing like RMInteractiveSource and MapBox-specific improvements to RMMarker, my implementations of these two tile sources differs slightly as well. Since both are specific to MapBox, maybe it makes more sense to just maintain them in our fork? I know that I've contributed to them in the past to route-me/route-me as well, though…

Anyway, curious about your thoughts. No big deal either way. but I don't anticipate pushing changes to them up to your project unless critical...

trasch commented Aug 1, 2012

Agreed, MapBox customers probably already use your fork so it's redundant here. I'll remove them.

@trasch trasch added a commit that referenced this issue Aug 1, 2012

@trasch trasch o Removed RMMapBoxSource and RMMBTilesSource since MapBox customers p…
…robably already use the MapBox fork (closes Alpstein/route-me/#92)
d75f59e

@trasch trasch closed this Aug 1, 2012

Right, so that totally broke my build. Where is the @incanus fork you guys where talking about?

incanus commented Oct 17, 2012

You can find out more about it here: http://mapbox.com/mobile Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment