Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logos #2

Merged
merged 1 commit into from Dec 19, 2016
Merged

Add logos #2

merged 1 commit into from Dec 19, 2016

Conversation

@martynchamberlin
Copy link
Contributor

martynchamberlin commented Dec 19, 2016

This adds 90 new logos to Secrets. I've also changed the wildcards on a few preexisting ones to be more lenient. Looking forward to hearing what you think!

@pfandrade pfandrade merged commit b319974 into OuterCorner:master Dec 19, 2016
@pfandrade

This comment has been minimized.

Copy link
Member

pfandrade commented Dec 19, 2016

This is awesome! Thanks!

@martynchamberlin

This comment has been minimized.

Copy link
Contributor Author

martynchamberlin commented Dec 19, 2016

Yay! Any ideas when the next release of the app will be?

@pfandrade

This comment has been minimized.

Copy link
Member

pfandrade commented Dec 19, 2016

This doesn't require a new release, the app will check for updated logos once a week. You should be able to delete the Logos folder here:

~/Library/Containers/com.outercorner.osx.Secrets/Data/Library/Application\ Support/Outer\ Corner/Secrets/Logos

To force an update (requires an app restart).

@martynchamberlin martynchamberlin deleted the martynchamberlin:add-logos branch Dec 19, 2016
@martynchamberlin

This comment has been minimized.

Copy link
Contributor Author

martynchamberlin commented Dec 19, 2016

Cool!

Though you do have to do something on your end other than merge this, right? For example I'm noticing 3 sizes of the logos for every image in that directory.

@pfandrade

This comment has been minimized.

Copy link
Member

pfandrade commented Dec 19, 2016

Yes I do. I have a script that runs through the service map (and credit card map) and generates all the logos at the correct sizes.

I might stop sending the 3 versions in the future and let the client handle that (I would just send the larger version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.