Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make codecov upload step faster #35

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Make codecov upload step faster #35

merged 3 commits into from
Apr 6, 2022

Conversation

BeLeap
Copy link
Member

@BeLeap BeLeap commented Apr 6, 2022

Summary

codecov/codecov-action builds docker to upload coverage.
However, building docker is quite slow without cache.
So I changed it to use bash script directly.

Includes

  • Change codecov/codecov-action directly use bash script
  • Make codecov detect commit sha

Copy link
Member

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your work! ⏩

@BeLeap BeLeap merged commit fd5d0ae into main Apr 6, 2022
@BeLeap BeLeap deleted the fix/slow-coverage branch April 6, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants