Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
A concern has been raised here regarding a spec issue:
I've logged this for the person who made the post, as they are not on GitHub.
It looks like they are correct. Compare the comment here: https://github.com/P-H-C/phc-winner-argon2/blob/master/src/core.c#L187-L189 to the spec on Page 7. There's a difference here.
My guess would be that the second part of the
Err, I'm sorry, did you close this by mistake? I've just checked the PDF, and as far as I can tell, it still doesn't accurately describe the reference implementation. From page 7, (§3.3 Indexing):
If I read it correctly, item (1) is mistaken. The reference implementation does something different:
Though that sounds convoluted. Here's a more procedural formulation:
Having a discrepancy between the specs and the reference implementation causes serious confusion when we try to implement Argon2 independently. I suffered this confusion back in 2017. I expect other people will suffer the same. I strongly believe this issue should remain open until the specs are amended (possibly with a note indicated the difference between the original intent and what we ended up having), and the PDF re-generated.