Skip to content

Commit

Permalink
Avoid truncating "LOG_LTE_RRC_OTA_MSG_LOG_C" LTE RRC OTA packets as t…
Browse files Browse the repository at this point in the history
…heir displayed length, as the displayed length is not always present at the end of the log packet inner header, as we can see in the "LteRrcOtaPacketFmt_v7" structure from MobileInsight's source
  • Loading branch information
p1-mmr committed May 22, 2021
1 parent 51a6ee0 commit f658b9e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions modules/pcap_dump.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,7 @@ def on_log(self, log_type, log_payload, log_header, timestamp = 0):

header_spec = '<' + freq_type + 'HB4xH'

(freq, sfn, channel_type, length), signalling_message = unpack_from(header_spec, ext_header), ext_header[calcsize(header_spec):]

packet = signalling_message[:length]
(freq, sfn, channel_type, length), packet = unpack_from(header_spec, ext_header), ext_header[calcsize(header_spec):]

# GSMTAP definition:
# - https://github.com/wireshark/wireshark/blob/wireshark-2.5.0/epan/dissectors/packet-gsmtap.h
Expand Down

0 comments on commit f658b9e

Please sign in to comment.