New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display channels in Channel box #44

Merged
merged 4 commits into from Jun 26, 2015

Conversation

Projects
None yet
2 participants
@maniotrix
Collaborator

maniotrix commented Jun 26, 2015

No description provided.

@maniotrix

This comment has been minimized.

Show comment
Hide comment
@maniotrix

maniotrix Jun 26, 2015

Collaborator

Below is the demonstration of channels in gui. Channel box is populated with 20 channels with same configuration.

https://www.youtube.com/watch?v=bAUD6pMdsMQ

Collaborator

maniotrix commented on 3d58ad7 Jun 26, 2015

Below is the demonstration of channels in gui. Channel box is populated with 20 channels with same configuration.

https://www.youtube.com/watch?v=bAUD6pMdsMQ

@josejuansanchez

This comment has been minimized.

Show comment
Hide comment
@josejuansanchez

josejuansanchez Jun 26, 2015

Member

Only a minor issue about the PR.

I think that is better to place the tests folder into a separate folder out of the src folder. I like the way proposed in this link.

Member

josejuansanchez commented Jun 26, 2015

Only a minor issue about the PR.

I think that is better to place the tests folder into a separate folder out of the src folder. I like the way proposed in this link.

@maniotrix

This comment has been minimized.

Show comment
Hide comment
@maniotrix

maniotrix Jun 26, 2015

Collaborator

@josejuansanchez Ok I will do the same.

Collaborator

maniotrix commented Jun 26, 2015

@josejuansanchez Ok I will do the same.

@josejuansanchez

This comment has been minimized.

Show comment
Hide comment
@josejuansanchez
Member

josejuansanchez commented Jun 26, 2015

@maniotrix Thanks! :)

josejuansanchez added a commit that referenced this pull request Jun 26, 2015

Merge pull request #44 from maniotrix/gui
Display channels in Channel box

@josejuansanchez josejuansanchez merged commit 00816fb into P2PSP:gui Jun 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment