New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DoxyFile and Player's Surface key events and altered play button functionality #56

Merged
merged 6 commits into from Jul 30, 2015

Conversation

Projects
None yet
2 participants
@maniotrix
Collaborator

maniotrix commented Jul 25, 2015

No description provided.

@maniotrix

This comment has been minimized.

Show comment
Hide comment
@maniotrix

maniotrix Jul 28, 2015

Collaborator

closes #54

Collaborator

maniotrix commented Jul 28, 2015

closes #54

@josejuansanchez

This comment has been minimized.

Show comment
Hide comment
@josejuansanchez

josejuansanchez Jul 28, 2015

Member

@maniotrix I suggest to rename the Doxygen config file from doxy_config to doxygen.cfg and place it inside the doc folder.

Another suggestion is that I think is not a good idea to store the Doxygen HTML documentation in the repository.

I think we should find another solution to be able to keep the documentation updated.

Member

josejuansanchez commented Jul 28, 2015

@maniotrix I suggest to rename the Doxygen config file from doxy_config to doxygen.cfg and place it inside the doc folder.

Another suggestion is that I think is not a good idea to store the Doxygen HTML documentation in the repository.

I think we should find another solution to be able to keep the documentation updated.

@maniotrix

This comment has been minimized.

Show comment
Hide comment
@maniotrix

maniotrix Jul 29, 2015

Collaborator

Ok Doxygen config file will be renamed.

Collaborator

maniotrix commented Jul 29, 2015

Ok Doxygen config file will be renamed.

@maniotrix

This comment has been minimized.

Show comment
Hide comment
@maniotrix

maniotrix Jul 29, 2015

Collaborator

One solution would be to use github pages to host documentation.

Collaborator

maniotrix commented Jul 29, 2015

One solution would be to use github pages to host documentation.

@maniotrix

This comment has been minimized.

Show comment
Hide comment
@maniotrix

maniotrix Jul 29, 2015

Collaborator

I have updated player surface with key press events in place of mouse events. It is done according to the proposal which I mentioned in #15 issue.

Please review the changes.
Thanks.

Collaborator

maniotrix commented Jul 29, 2015

I have updated player surface with key press events in place of mouse events. It is done according to the proposal which I mentioned in #15 issue.

Please review the changes.
Thanks.

@maniotrix maniotrix changed the title from Added Doxygen Configuration File to Added DoxyFile and Player's Surface key events and altered play button functionality Jul 30, 2015

@josejuansanchez

This comment has been minimized.

Show comment
Hide comment
@josejuansanchez

josejuansanchez Jul 30, 2015

Member

Good work!

Member

josejuansanchez commented Jul 30, 2015

Good work!

josejuansanchez added a commit that referenced this pull request Jul 30, 2015

Merge pull request #56 from maniotrix/gui
Added DoxyFile and Player's Surface key events and altered play button functionality

@josejuansanchez josejuansanchez merged commit 7ae2519 into P2PSP:gui Jul 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment