Skip to content

Conversation

@Qanpi
Copy link

@Qanpi Qanpi commented Feb 5, 2025

…errors on build (#493)

Fixes #493

Proposed Changes

  • change module resolution to 'node', bundler fails to properly resolve type imports for whatever reason
  • change default function exports to const and default exports (again, seems to be necessary probably because of some unique bundler issue)

Additional Notes (optional)

@Qanpi Qanpi mentioned this pull request Feb 5, 2025
@jamesrweb jamesrweb merged commit d741337 into P5-wrapper:v5.x.x-fixes Feb 5, 2025
@yevdyko
Copy link
Contributor

yevdyko commented Feb 5, 2025

FYI: While I was testing, I discovered the following. It seems that the changes in the default function export are not related to the failed build, but they can be updated too.

@yevdyko
Copy link
Contributor

yevdyko commented Feb 5, 2025

FYI @jamesrweb @Qanpi I played around a bit with tsconfig and the only thing that matters is defining the composite value as false, the module resolution type has no effect on build errors and works fine in a more modern option like bundler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants