New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial cherry pick of PR 759 for ical3 #910

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
5 participants
@mike0042
Copy link
Collaborator

mike0042 commented Dec 4, 2018

Bug/feature Description

  • PBS Pro build fails on CentOS 7.6 because it uses ical3 where icaltime_from_timet() is deprecated
  • This has already been fixed in master with PR #759
  • Performed a partial cherry pick from PR #759
  • This was identified when OpenHPC add CentOS 7.6 to their builds

Affected Platform(s)

  • CentOS 7.6

Cause / Analysis / Design

  • icaltime_from_timet() is deprecated, don't use it

Solution Description

  • Replace instances of icaltime_from_timet() with icaltime_from_timet_with_zone()

Testing logs/output

Checklist:

***For further information please visit the Developer Guide Home.***

@bayucan

bayucan approved these changes Dec 4, 2018

Copy link
Contributor

bayucan left a comment

Looks good.

@bhroam

bhroam approved these changes Dec 4, 2018

Copy link
Contributor

bhroam left a comment

Looks good. I sign off.

@mike0042

This comment has been minimized.

Copy link
Collaborator

mike0042 commented Dec 5, 2018

I'm going to squash these commits. Nobody needs to see multiple attempts at making OpenSUSE work for TravisCI. The original commit affected the one C file in this PR and hasn't changed. The rest were for TravisCI. Please note I had to disable -Werror for the OpenSUSE build because this branch doesn't have all of the warnings fixed like master.

@mike0042 mike0042 force-pushed the mike0042:ical3 branch from 3eb8e4a to e30ad97 Dec 5, 2018

@mike0042

This comment has been minimized.

Copy link
Collaborator

mike0042 commented Dec 5, 2018

FYI... the changes to Travis were necessary because the old OpenSUSE repo URL is gone. It appears to have been updated earlier today. We were forced to transition to Leap as we do for master.

@bayucan

bayucan approved these changes Dec 5, 2018

Copy link
Contributor

bayucan left a comment

Still looks good.

@mike0042

This comment has been minimized.

Copy link
Collaborator

mike0042 commented Dec 5, 2018

Could you please merge this change and tag it as 18.1.4 @subhasis?

@mike0042

This comment has been minimized.

Copy link
Collaborator

mike0042 commented Dec 7, 2018

Please have a look at this when you get the chance @subhasisb.

adrianreber added a commit to adrianreber/ohpc that referenced this pull request Dec 11, 2018

Fix pbspro build failure on Centos 7.6
Patch taken from PBSPro/pbspro#910

Signed-off-by: Adrian Reber <areber@redhat.com>
@mike0042

This comment has been minimized.

Copy link
Collaborator

mike0042 commented Dec 12, 2018

If we do release 18.1.4 this PR should be included. Closing for now since the OpenHPC folks have created a patch for the same changes.

@mike0042 mike0042 closed this Dec 12, 2018

@mike0042 mike0042 reopened this Dec 18, 2018

@mike0042

This comment has been minimized.

Copy link
Collaborator

mike0042 commented Dec 18, 2018

There has been a request on the forum for this change to be merged into the release_18_1_branch:
http://community.pbspro.org/t/pbspro-build-failure-on-centos7-with-branch-release-18-1-branch/1358

@guillaumeeb

This comment has been minimized.

Copy link

guillaumeeb commented Dec 18, 2018

I confirm this is interesting to me, thanks @mike0042!

@mike0042

This comment has been minimized.

Copy link
Collaborator

mike0042 commented Dec 21, 2018

@PBSPro/pbspro-maintainers please take this forward.

@agrawalravi90 agrawalravi90 merged commit e30ad97 into PBSPro:release_18_1_branch Dec 21, 2018

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment