New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepwork - Moved PF Align, Stats, and Saves from System to Data. #590
Conversation
@thpr & @jdempsey-au I'm not familiar with the Orphan Test parameters, but it's not recognizing the new file formats. GM MovedSAVE:cr__saves.lst |
See PR#592 |
@thpr see - https://travis-ci.org/PCGen/pcgen/builds/79414799, still thinks the file types are invalid.
|
|
||
|
||
|
||
MODIFYOTHER:EQUIPMENT.PART|ALL|CritRange|SOLVE|value()+EqCritRange |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why MODIFYOTHER on CritRange? This won't work until formula is integrated
# Formula Parser | ||
############################ | ||
|
||
###Block: Formula NAMESPACEDEF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer valid per discussion on _exp
I am unable to reproduce the problem locally (if I create an alignment file and put the appropriate token in a PCC file) |
resubmitting new PR, this one required a rebase and conflict resolution. |
No description provided.