Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepwork - Moved PF Align, Stats, and Saves from System to Data. #590

Closed
wants to merge 5 commits into from

Conversation

LegacyKing
Copy link
Member

No description provided.

@LegacyKing LegacyKing changed the title Prepwork Prepwork - Moved PF Align, Stats, and Saves from System to Data. Sep 9, 2015
@LegacyKing
Copy link
Member Author

@thpr & @jdempsey-au I'm not familiar with the Orphan Test parameters, but it's not recognizing the new file formats.
#VARIABLE:cr__variables.lst
#GLOBALMODIFIER:cr__globalmodifiers.lst

GM Moved

SAVE:cr__saves.lst
STAT:cr__stats.lst
ALIGNMENT:cr__alignments.lst

@thpr
Copy link
Contributor

thpr commented Sep 9, 2015

See PR#592

@LegacyKing
Copy link
Member Author

@thpr see - https://travis-ci.org/PCGen/pcgen/builds/79414799, still thinks the file types are invalid.


pcgen.persistence.lst.DataTest > orphanFilesTest FAILED

    org.junit.ComparisonFailure: Some data files are orphaned. expected:<[]> but was:<[pathfinder/paizo/roleplaying_game/core_rulebook/cr__alignments.lst

    pathfinder/paizo/roleplaying_game/core_rulebook/cr__globalmodifiers.lst

    pathfinder/paizo/roleplaying_game/core_rulebook/cr__saves.lst

    pathfinder/paizo/roleplaying_game/core_rulebook/cr__stats.lst

    pathfinder/paizo/roleplaying_game/core_rulebook/cr__variables.lst

    ]>

        at org.junit.Assert.assertEquals(Assert.java:115)

        at pcgen.persistence.lst.DataTest.orphanFilesTest(DataTest.java:252)

14 tests completed, 1 failed```




MODIFYOTHER:EQUIPMENT.PART|ALL|CritRange|SOLVE|value()+EqCritRange
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why MODIFYOTHER on CritRange? This won't work until formula is integrated

# Formula Parser
############################

###Block: Formula NAMESPACEDEF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer valid per discussion on _exp

@thpr
Copy link
Contributor

thpr commented Sep 11, 2015

I am unable to reproduce the problem locally (if I create an alignment file and put the appropriate token in a PCC file)

@LegacyKing
Copy link
Member Author

resubmitting new PR, this one required a rebase and conflict resolution.

@LegacyKing LegacyKing closed this Sep 11, 2015
@LegacyKing LegacyKing deleted the prepwork branch September 13, 2015 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants