Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch_time_in_parent global attribute #386

Closed
aradhakrishnanGFDL opened this issue Aug 3, 2018 · 5 comments · Fixed by #388
Closed

branch_time_in_parent global attribute #386

aradhakrishnanGFDL opened this issue Aug 3, 2018 · 5 comments · Fixed by #388

Comments

@aradhakrishnanGFDL
Copy link

@aradhakrishnanGFDL aradhakrishnanGFDL commented Aug 3, 2018

Hi @doutriaux1

If there is no parent experiment, is it correct that branch_time_in_parent can be omitted or set to the 0.
per https://www.earthsystemcog.org/site_media/projects/wip/CMIP6_global_attributes_filenames_CVs_v6.2.6.pdf

Or, is this attribute mandatory for PrePARE? We ask because we ran into an issue with this recently (CIM expects omission I think)

https://github.com/PCMDI/cmor/blob/master/LibCV/PrePARE/PrePARE.py#L449

@doutriaux1

This comment has been minimized.

Copy link
Contributor

@doutriaux1 doutriaux1 commented Aug 3, 2018

@aradhakrishnanGFDL this is definitely a question for @taylor13, sorry about that. I think @taylor13 might be off today.

@doutriaux1

This comment has been minimized.

Copy link
Contributor

@doutriaux1 doutriaux1 commented Aug 3, 2018

@aradhakrishnanGFDL I chit-chatted with @durack1 about this. Our expectation is that it should. Please let me know if it doesn't.

@taylor13

This comment has been minimized.

Copy link
Contributor

@taylor13 taylor13 commented Aug 3, 2018

This is the same bug as identified 5 days ago in #375
If no parent, CMOR/PrePARE should be consistent with https://www.earthsystemcog.org/site_media/projects/wip/CMIP6_global_attributes_filenames_CVs_v6.2.6.pdf

@doutriaux1

This comment has been minimized.

Copy link
Contributor

@doutriaux1 doutriaux1 commented Aug 3, 2018

@taylor13 thanks. Ok so it will be fixed shortly (hopefully today)

@aradhakrishnanGFDL

This comment has been minimized.

Copy link
Author

@aradhakrishnanGFDL aradhakrishnanGFDL commented Aug 3, 2018

@doutriaux1 A colleague of mine ran into an error when this attribute was omitted in the netCDF file (PrePARE on esgf).
But, in the version of PrePARE I installed from conda (pcmdi/label/nightly) yesterday, I do not run into this error ..i.e. no complaints if the attribute branch_time_in_parent is missing. In my test case, there is no parent. So, this seems like what we'd like at this time. I am still trying to understand why my colleague (also Guillaume #375) may have run into this issue..checking versions and such so I am not missing anything

doutriaux1 added a commit that referenced this issue Aug 3, 2018
fix #375
fix #386 applies @glevava fixes
@doutriaux1 doutriaux1 mentioned this issue Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.