Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table filename and "table_id" need to match #27

Closed
durack1 opened this issue Nov 3, 2023 · 5 comments
Closed

table filename and "table_id" need to match #27

durack1 opened this issue Nov 3, 2023 · 5 comments
Assignees

Comments

@durack1
Copy link
Contributor

durack1 commented Nov 3, 2023

The table filename and the table_id in the file need to match, so e.g.,:

"table_id": "ACmon"

Needs to become

"table_id": "MIP_ACmon"

@wolfiex @matthew-mizielinski ping

@matthew-mizielinski
Copy link
Collaborator

Hi @durack1 ,

If the above change is implemented we'll end up with "MIP_" embedded in the filenames. The table_id entry in the CVs needs to be consistent with the table_id value here, so I think it is the CVs that need to change.

@durack1
Copy link
Contributor Author

durack1 commented Nov 6, 2023

@matthew-mizielinski yes that was what I had thought would be useful, so that we follow the same notation as in the past CMIP5_Amon, CMIP6_Amon. I figure that having the MIP prefix means at least there is some additional context to APmon etc, but happy to chat about this - it is 4 repeating characters for every single entry

@matthew-mizielinski
Copy link
Collaborator

matthew-mizielinski commented Nov 7, 2023

@durack1, Just in case I wasn't clear above, with this change the netcdf output files would be named, for example,

tas_MIP_APmon_HadGEM3-GC31-LL_hist-lu_f2023-r12i1p1f3_gn_190001-195012.nc

i.e. what would appear to be an extra facet within the output netCDF file names.

I'm not particularly keen on this as it breaks a lot of the file naming patterns we've had for CMIP6 without a huge amount of benefit. If you want to clearly credit the table names I would suggest you consider how the table_info field is used by CMOR as this will end up in global attributes.

@taylor13
Copy link
Collaborator

taylor13 commented Nov 7, 2023

Like Matt, my take is that "MIP" contains no distinguishing information among datasets, except to limit what table names might follow it. Seems like it unnecessarily increases the apparent complexity of the filename.

@durack1
Copy link
Contributor Author

durack1 commented Nov 7, 2023

@taylor13 @matthew-mizielinski absolutely agree now that the example is clear. In CMIP6, we had
"table_id": "Table Amon",

And CMIP5, we had
table_id: Table Amon

And CMIP3, we had
table_id: Table A1 ! table id

All had the redundant "Table " prefix, which I agree should be removed.

@wolfiex wolfiex self-assigned this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants