-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table filename and "table_id" need to match #27
Comments
Hi @durack1 , If the above change is implemented we'll end up with "MIP_" embedded in the filenames. The table_id entry in the CVs needs to be consistent with the table_id value here, so I think it is the CVs that need to change. |
@matthew-mizielinski yes that was what I had thought would be useful, so that we follow the same notation as in the past CMIP5_Amon, CMIP6_Amon. I figure that having the MIP prefix means at least there is some additional context to APmon etc, but happy to chat about this - it is 4 repeating characters for every single entry |
@durack1, Just in case I wasn't clear above, with this change the netcdf output files would be named, for example,
i.e. what would appear to be an extra facet within the output netCDF file names. I'm not particularly keen on this as it breaks a lot of the file naming patterns we've had for CMIP6 without a huge amount of benefit. If you want to clearly credit the table names I would suggest you consider how the table_info field is used by CMOR as this will end up in global attributes. |
Like Matt, my take is that "MIP" contains no distinguishing information among datasets, except to limit what table names might follow it. Seems like it unnecessarily increases the apparent complexity of the filename. |
@taylor13 @matthew-mizielinski absolutely agree now that the example is clear. In CMIP6, we had And CMIP5, we had And CMIP3, we had All had the redundant "Table " prefix, which I agree should be removed. |
The table filename and the
table_id
in the file need to match, so e.g.,:mip-cmor-tables/Tables/MIP_ACmon.json
Line 13 in 490b9b8
Needs to become
@wolfiex @matthew-mizielinski ping
The text was updated successfully, but these errors were encountered: