Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landsea mask generation: add PCMDI method as an option #1063

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Landsea mask generation: add PCMDI method as an option #1063

merged 7 commits into from
Feb 29, 2024

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Feb 28, 2024 •
edited
Loading

The PCMDI method (Taylor and Doutriaux, 2000) is added for land mask generation.

Usage:

from pcmdi_metrics.utils import create_land_sea_mask

mask = create_land_sea_mask(ds, method="pcmdi")

@lee1043 lee1043 requested a review from bosup February 28, 2024 05:58
@lee1043
Copy link
Contributor Author

lee1043 commented Feb 28, 2024

Jupyter notebook for testing (please uncompress once downloaded):
test_landmask_generation.ipynb.zip

@lee1043
Copy link
Contributor Author

lee1043 commented Feb 28, 2024

@bosup would you be able to check if this work for you?

@lee1043
Copy link
Contributor Author

lee1043 commented Feb 28, 2024

The code is now ready for review.

bosup
bosup approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@bosup bosup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@lee1043 lee1043 merged commit cd18d8a into main Feb 29, 2024
5 checks passed
@lee1043 lee1043 deleted the enable_regrid2_landmask branch February 29, 2024 00:07
@lee1043
Copy link
Contributor Author

lee1043 commented Feb 29, 2024

@bosup thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosup bosup bosup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lee1043 @bosup