Skip to content
Permalink
Browse files

CDVD: Add configurable directory for blockdumps storage

Previously the blockdumps will be automatically stored in the root directory of PCSX2, added an INI option in "PCSX2_ui.ini" named "CurrentBlockdump" to modify the directory to whatever is preferred by the user. (Some people were requesting for this)

A GUI could also be added if anyone wants, but considering the popularity of this I'm not sure as blockdumps will only be used my less percentile of users and mostly by testers and developers for debugging.
  • Loading branch information...
ssakash committed Jun 30, 2019
1 parent ba2efec commit 7290576a2aac1925b00aef729a79a662166a8410
Showing with 6 additions and 3 deletions.
  1. +4 −3 pcsx2/CDVD/CDVDaccess.cpp
  2. +1 −0 pcsx2/gui/AppConfig.cpp
  3. +1 −0 pcsx2/gui/AppConfig.h
@@ -370,16 +370,17 @@ bool DoCDVDopen()
return true;
}

// TODO: Add a blockdumps configurable folder, and use that instead of CWD().

// TODO: "Untitled" should use pnach/slus name resolution, slus if no patch,
// and finally an "Untitled-[ElfCRC]" if no slus.

wxString somepick( Path::GetFilenameWithoutExt( m_SourceFilename[CurrentSourceType] ) );
if( somepick.IsEmpty() )
somepick = L"Untitled";

wxString temp( Path::Combine( wxGetCwd(), somepick ) );
if (g_Conf->CurrentBlockdump.IsEmpty())
g_Conf->CurrentBlockdump = wxGetCwd();

This comment has been minimized.

Copy link
@lightningterror

lightningterror Jun 30, 2019

Member

I'd prefer if we use tabs instead of spaces on new rows for consistency with the rest of the code.


wxString temp(Path::Combine(g_Conf->CurrentBlockdump, somepick));

#ifdef ENABLE_TIMESTAMPS
wxDateTime curtime( wxDateTime::GetTimeNow() );
@@ -640,6 +640,7 @@ void AppConfig::LoadSaveRootItems( IniInterface& ini )
ini.Entry( L"CurrentIso", res, res, ini.IsLoading() || IsPortable() );
CurrentIso = res.GetFullPath();

IniEntry( CurrentBlockdump );
IniEntry( CurrentELF );
IniEntry( CurrentIRX );

@@ -323,6 +323,7 @@ class AppConfig
bool AskOnBoot;

wxString CurrentIso;
wxString CurrentBlockdump;
wxString CurrentELF;
wxString CurrentIRX;
CDVD_SourceType CdvdSource;

1 comment on commit 7290576

@lightningterror

This comment has been minimized.

Copy link
Member

commented on 7290576 Jun 30, 2019

I think there was an open issue about this.

Please sign in to comment.
You can’t perform that action at this time.