Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Doko Demo Issho - Toro to Ippai (Japan) and Toro to Kyuujitsu (Japan) - Wireframe issues on OGL #4674

Closed
HeroponRikiBestest opened this issue Aug 17, 2021 · 10 comments · Fixed by #5518

Comments

@HeroponRikiBestest
Copy link

HeroponRikiBestest commented Aug 17, 2021

Describe the Bug

In Doko Demo Issho - Toro to Ippai (Japan); all Toros are rendered with their wireframe missing on OGL. Additionally, even in software mode, the black Toros seem to have texture issues with their eyes.
In Toro to Kyuujitsu (Japan); Toro is rendered with only his wireframe on OGL, as well as the 3d model of a hand that acts as your mouse. As far as I know, there are no black Toros in this game to check.

Reproduction Steps

Doko Demo Issho - Toro to Ippai (Japan): Wait until the title screen appears
Toro to Kyuujitsu (Japan): Start a new game, get past the character customization menu.

Expected Behavior

Models of Toro (and in the case of Toro to Kyuujitsu, the mouse/hand icon as well) should appear whole, with both the wireframe and the rest of the model intact. Additionally, the black toros should not have eye texture issues.

PCSX2 Revision

PCSX2 1.7.0-20210817085737 - compiled on Aug 17 2021

Operating System

Linux (64bit) - Specify Distro Below

If Linux - Specify Distro

Linux Mint 20

CPU

AMD Ryzen 7 PRO 4750U with Radeon Graphics

GPU

Uses an iGPU, see cpu

GS Settings

No response

Emulation Settings

No response

GS Window Screenshots

Doko Demo Issho - Toro to Ippai (Japan): Software mode (Eye texture issues visible)
image
Doko Demo Issho - Toro to Ippai (Japan): Hardware mode
image

Toro to Kyuujitsu (Japan): Software mode
image
Toro to Kyuujitsu (Japan): Hardware/OGL mode
image

Logs & Dumps

In Doko Demo Issho - Toro to Ippai (Japan), when you reach the title screen (the first place where the Toro models show up) the following displays in the log:

microVU0: Cached Prog = [000] [PC=02c8] [List=01] (Cache=0.000%) [0.0mb]
microVU0: Cached Prog = [001] [PC=02d8] [List=01] (Cache=0.000%) [0.0mb]
microVU0: Cached Prog = [002] [PC=0140] [List=01] (Cache=0.005%) [0.0mb]
microVU0: Cached Prog = [003] [PC=0150] [List=01] (Cache=0.005%) [0.0mb]
microVU0: Cached Prog = [004] [PC=0160] [List=01] (Cache=0.009%) [0.0mb]
microVU0: Cached Prog = [005] [PC=0170] [List=01] (Cache=0.009%) [0.0mb]
microVU0: Cached Prog = [006] [PC=06a0] [List=01] (Cache=0.013%) [0.0mb]
microVU0: Cached Prog = [007] [PC=06b0] [List=01] (Cache=0.013%) [0.0mb]
microVU0: Cached Prog = [008] [PC=06e0] [List=01] (Cache=0.032%) [0.0mb]
microVU0: Cached Prog = [009] [PC=0708] [List=01] (Cache=0.032%) [0.0mb]
microVU0: Cached Prog = [010] [PC=0738] [List=01] (Cache=0.032%) [0.0mb]
microVU0: Cached Prog = [011] [PC=0768] [List=01] (Cache=0.032%) [0.0mb]
microVU1: Cached Prog = [000] [PC=0000] [List=01] (Cache=0.000%) [0.0mb]
microVU1: Cached Prog = [001] [PC=0490] [List=01] (Cache=0.000%) [0.0mb]
microVU1: Cached Prog = [002] [PC=04a0] [List=01] (Cache=0.060%) [0.0mb]
microVU1: Cached Prog = [003] [PC=0ed8] [List=01] (Cache=0.060%) [0.0mb]
microVU0: Cached Prog = [012] [PC=0530] [List=01] (Cache=0.074%) [0.0mb]
microVU0: Cached Prog = [013] [PC=0568] [List=01] (Cache=0.074%) [0.0mb]
microVU0: Cached Prog = [014] [PC=0588] [List=01] (Cache=0.074%) [0.0mb]
microVU1: Cached Prog = [004] [PC=2da8] [List=01] (Cache=0.148%) [0.1mb]
recVifUnpk: Bucket 0x1905 has 4 micro-programs
microVU1: Cached Prog = [005] [PC=1800] [List=01] (Cache=0.171%) [0.1mb]
recVifUnpk: Bucket 0x1902 has 4 micro-programs
microVU1: Cached Prog = [006] [PC=20e0] [List=01] (Cache=0.197%) [0.1mb]
microVU1: Cached Prog = [007] [PC=1258] [List=01] (Cache=0.207%) [0.1mb]
microVU1: Cached Prog = [008] [PC=0a60] [List=01] (Cache=0.230%) [0.1mb]
microVU1: Cached Prog = [009] [PC=05a0] [List=01] (Cache=0.247%) [0.2mb]
microVU1: Cached Prog = [010] [PC=05b0] [List=01] (Cache=0.248%) [0.2mb]
microVU1: 1 cycle stall on branch instruction [06f8]
recVifUnpk: Bucket 0x1903 has 4 micro-programs
recVifUnpk: Bucket 0x1907 has 4 micro-programs
recVifUnpk: Bucket 0x1908 has 4 micro-programs
recVifUnpk: Bucket 0x1904 has 4 micro-programs
recVifUnpk: Bucket 0x1909 has 4 micro-programs
recVifUnpk: Bucket 0x190d has 4 micro-programs
recVifUnpk: Bucket 0x1906 has 4 micro-programs
recVifUnpk: Bucket 0x1918 has 4 micro-programs
recVifUnpk: Bucket 0x190a has 4 micro-programs
recVifUnpk: Bucket 0x190c has 4 micro-programs

In Toro to Kyuujitsu (Japan), just when Toro starts talking, the following displays. However, this is after his model has already been onscreen for a second, so it's possibly unrelated to the issue.

ADPCM : volume = 0.
ADPCM : Intr delete.
ADPCM : delete sema ok.
ADPCM : ### Main thread sleep.  ###
CDVD : init = 1
Stream Buffer 1Bank 32768byte 5banks 163840byte used
load:              TOROQ¥CHR¥TORO.DIC   0.00sec 0.12sec
load:               TOROQ¥CHR¥JUN.DIC   0.00sec 0.12sec
load:            TOROQ¥CHR¥SUZUKI.DIC   0.00sec 0.13sec
load:             TOROQ¥CHR¥RICKY.DIC   0.00sec 0.05sec
load:            TOROQ¥CHR¥PIERRE.DIC   0.00sec 0.05sec
load:            TOROQ¥CHR¥TORO02.MBF   0.00sec 0.82sec
load:     TOROQ¥SCENE¥SCRIPT¥KEEP.MBF   0.00sec 0.20sec
load:TOROQ¥COMMON¥A_MENU¥MENUBACK.TM2   0.00sec 0.10sec
load:    TOROQ¥COMMON¥A_MENU¥FONT.TM2   0.00sec 0.05sec
load:    TOROQ¥COMMON¥A_MENU¥MENU.TM2   0.00sec 0.00sec
load:         TOROQ¥CHR¥TORO¥IDLE.BPK   0.00sec 0.90sec
load:     TOROQ¥SCENE¥TV¥FRAME336.TM2   0.00sec 0.10sec
load:     TOROQ¥SCENE¥TV¥FRAME311.TM2   0.00sec 0.00sec
load:          TOROQ¥SCENE¥TV¥336.TM2   0.00sec 0.02sec
load:          TOROQ¥SCENE¥TV¥311.TM2   0.00sec 0.02sec
load:       TOROQ¥SCENE¥TV¥TV_SCH.BIN   0.00sec 0.03sec
load:        TOROQ¥COMMON¥POLYCUR.BND   0.00sec 0.17sec
load:    TOROQ¥SCENE¥SCRIPT¥SC000.MBF   0.00sec 0.18sec
> Key: Right (Code: 316)
load: TOROQ¥SCENE¥SCEN336¥SCEN336.SDF   0.00sec 0.10sec
load:         TOROQ¥SCENE¥BLOCK40.BND   0.00sec 0.63sec
load:    TOROQ¥SCENE¥SCRIPT¥SC336.MBF   0.00sec 0.23sec
'TOROQ¥CHR¥TORO¥336M.DAT' loaded from BLOCK-PACKING file.
PokepBufferFree 1560272
load:     TOROQ¥SOUND¥DAT¥SNDB40A.BND   0.00sec 0.32sec
sound : It transfers 'BlockSE' data to SPU.
>>
FBCTRL.C:not found a file 'T0.BD'.
FBCTRL.C:not found a file 'T0.HD'.
sound : It is OK even if there is not 'Bird' at this block.
sound : It transfers 'BaseEnv' data to SPU.
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
FBCTRL.C:not found a file 'TOROQ¥SCENE¥SCEN336¥SPR33601.ETM'.
TV:ゲーム時間1日目 テレビリストの曜日1の 9時のデータを使用します。
今回のテレビ番組ファイルは TOROQ¥SCENE¥TV¥NHKnews.BINです。
load:      TOROQ¥SCENE¥TV¥NHKnews.BIN   0.00sec 0.17sec
>>>>>>>>>
'TOROQ¥SCENE¥SCEN336¥MAC.DAT' loaded from BLOCK-PACKING file.
env_snd : The environment sound of this scene is 'A40336A.SQ'
info : Sound data every scene was normally set.
microVU1: Cached Prog = [000] [PC=0000] [List=01] (Cache=0.000%) [0.0mb]
microVU1: Cached Prog = [001] [PC=0af0] [List=01] (Cache=0.000%) [0.0mb]
microVU1: Cached Prog = [002] [PC=0b00] [List=01] (Cache=0.043%) [0.0mb]
microVU1: Cached Prog = [003] [PC=0ef0] [List=01] (Cache=0.043%) [0.0mb]
microVU1: Cached Prog = [004] [PC=0b20] [List=01] (Cache=0.043%) [0.0mb]
microVU1: Cached Prog = [005] [PC=0b30] [List=01] (Cache=0.061%) [0.0mb]
microVU1: Cached Prog = [006] [PC=0b40] [List=01] (Cache=0.062%) [0.0mb]
microVU1: Cached Prog = [007] [PC=1020] [List=01] (Cache=0.062%) [0.0mb]
microVU1: Cached Prog = [008] [PC=0b60] [List=01] (Cache=0.062%) [0.0mb]
microVU1: Cached Prog = [009] [PC=0a30] [List=01] (Cache=0.090%) [0.1mb]
microVU1: Cached Prog = [010] [PC=0a40] [List=01] (Cache=0.091%) [0.1mb]
microVU1: Cached Prog = [011] [PC=0d70] [List=01] (Cache=0.091%) [0.1mb]
microVU1: Cached Prog = [012] [PC=15e8] [List=01] (Cache=0.091%) [0.1mb]
microVU1: Cached Prog = [013] [PC=0d88] [List=01] (Cache=0.091%) [0.1mb]
microVU1: Cached Prog = [014] [PC=1828] [List=01] (Cache=0.091%) [0.1mb]
microVU1: Cached Prog = [015] [PC=0da0] [List=01] (Cache=0.091%) [0.1mb]
microVU1: Cached Prog = [016] [PC=0e00] [List=01] (Cache=0.091%) [0.1mb]
recVifUnpk: Bucket 0x0c02 has 4 micro-programs
microVU1: Cached Prog = [017] [PC=08b0] [List=01] (Cache=0.178%) [0.1mb]
microVU1: Cached Prog = [018] [PC=08c0] [List=01] (Cache=0.179%) [0.1mb]
microVU1: Cached Prog = [019] [PC=0bf0] [List=01] (Cache=0.179%) [0.1mb]
microVU1: Cached Prog = [020] [PC=0c08] [List=01] (Cache=0.179%) [0.1mb]
microVU1: Cached Prog = [021] [PC=0c20] [List=01] (Cache=0.179%) [0.1mb]
microVU1: Cached Prog = [022] [PC=0c80] [List=01] (Cache=0.179%) [0.1mb]
Available VRAM is very low (-3717024), a crash is expected! Enable conservative buffer allocation or reduce upscaling!
GS OUT OF MEMORY
microVU1: Cached Prog = [023] [PC=03a8] [List=01] (Cache=0.205%) [0.1mb]
microVU1: Cached Prog = [024] [PC=03b8] [List=01] (Cache=0.206%) [0.1mb]
microVU1: 1 cycle stall on branch instruction [04d8]
microVU1: 1 cycle stall on branch instruction [0530]
microVU1: Cached Prog = [025] [PC=0b08] [List=01] (Cache=0.206%) [0.1mb]
recVifUnpk: Bucket 0x0c0e has 4 micro-programs
recVifUnpk: Bucket 0x0c0a has 4 micro-programs
recVifUnpk: Bucket 0x0c08 has 4 micro-programs
recVifUnpk: Bucket 0x0c08 has 5 micro-programs
recVifUnpk: Bucket 0x0c06 has 4 micro-programs
microVU1: Cached Prog = [026] [PC=0a48] [List=01] (Cache=0.239%) [0.1mb]
recVifUnpk: Bucket 0x0c12 has 4 micro-programs
recVifUnpk: Bucket 0x0c0c has 4 micro-programs
recVifUnpk: Bucket 0x0c04 has 4 micro-programs
recVifUnpk: Bucket 0x0c04 has 5 micro-programs
microVU1: Cached Prog = [027] [PC=08c8] [List=01] (Cache=0.289%) [0.2mb]
recVifUnpk: Bucket 0x0c16 has 4 micro-programs
recVifUnpk: Bucket 0x0c14 has 4 micro-programs
recVifUnpk: Bucket 0x0c10 has 4 micro-programs
Read Time Out 5000(msec)
@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Aug 19, 2021

In software mode as long as you have Edge AA enabled, it looks perfect, no wireframe visible at all (including the eyes).

That said, I don't know what it needs in HW mode to not look completely wireframe, though I expect the closest we'll get is like Software without Edge AA

@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Aug 19, 2021

Fixed in #4682 for SW Mode or by enabling Edge Anti-Aliasing if it's disabled
Hardware mode will have to come much later, if it ever happens.

@lightningterror
Copy link
Contributor

Latest master improves the handling of these games.

@HeroponRikiBestest
Copy link
Author

Latest master improves the handling of these games.

Just curious, how has handling of these games improved? They look identical to me.

@refractionpcsx2
Copy link
Member

Latest master improves the handling of these games.

Just curious, how has handling of these games improved? They look identical to me.

Master modified the handling of AA lines in hardware mode so hardware mode doesn't look terrible. Software mode didn't change.

@lightningterror
Copy link
Contributor

Latest master improves the handling of these games.

Just curious, how has handling of these games improved? They look identical to me.

image

@HeroponRikiBestest
Copy link
Author

Ohh, ok, I see. I was just looking at Toro to Kyuujitsu, it seems the changes only effected Toro to Ippai. My bad.
image

@refractionpcsx2
Copy link
Member

was kinda hoping it would affect both, that's a shame :(

@lightningterror
Copy link
Contributor

Ohh, ok, I see. I was just looking at Toro to Kyuujitsu, it seems the changes only effected Toro to Ippai. My bad. image

You need to disable depth emulation for this one in hw hacks.

@HeroponRikiBestest
Copy link
Author

HeroponRikiBestest commented Dec 12, 2021

Ah, ok. Toro still looks a big bugged, but yeah, definitely a huge improvement.
image

Worth noting:
Toro to Ippai suffers from mipmapping issues on HW, visible immediately with the plant on (your) right of the opening door. On SW, it stays nice and blurry the whole time. On hardware with Mipmapping set to automatic, the plant is far sharper than it's supposed to be. On hardware with Mipmapping set to Basic or Fast, the plant keeps jumping between being sharp and being blurry depending on where the camera is. I didn't include any pictures because I'd need a bunch to show absolutely everything, and I did the gsdump on Hardware with mipmapping set to automatic. I couldn't do a long gsdump because of the issues I've discussed in discord with how the linux version of PCSX2 handles GSdumps. Please lmk if you need more.
gs_20211212090941.gs.zip
Toro to Ippai suffers from issues with the ground texture on HW.
image
image
gs_20211212090616.gs.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants