Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
PCSX2-WX: Add restore defaults button to GS panel #2003
Summary of changes:
Initially, I was planning on adding it for all the dialogs but it seems pointless to add it to Gamefixes panel as you can just uncheck the
I don't see how it's better, it looks sort of awkward to me to have it at the same level as
I just placed the
Yes I know that it is the same issue for others tabs. It wasn't directly related to this PR.
It is strange to have a default button at various location which depends on the current tab. Here it is fine but it takes too much room on the speedhack panel (people still have low height display). Besides, maybe it would be better to have a single restore default button that restore all default instead of the current tab option (except if the use case is to only "default" a single tab).
Why ? I mean all 4 buttons control the settings. You can validate the settings, you can discard the settings. It feels logical to be able to reset the settings too. The fact that you need to duplicate it in all tabs is a proof that it doesn't belong to a tab.
Yeah, thanks for repudiating your own suggestion by providing a counter-argument along with it. :P
Let's assume a certain scenario with your global restore defaults idea,
Also it's not used enough to place it near the global
Well, there's no other way, It needs to be duplicated in every single tab if we need a button which restores only the current tab's options to defaults.
Not really a counter argument. Even if you put the button in the bar, you can still code it to reset only the current tab.
The fact is that this button consume too much space in the speedhack panel. So far the solutions are
Technically it would be the same story for the gamefix panel... But I guess it won't have it.
Anyway, I'm not against your PR.