New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx: Add hidden option to disable Nvidia hack #2145

Merged
merged 1 commit into from Dec 10, 2017

Conversation

Projects
None yet
4 participants
@lightningterror
Member

lightningterror commented Nov 25, 2017

Add hidden option "UserHacks_DisableNVhack" to disable
the Nvidia hack on Direct3D which added black lines on the right
and bottom of the screen. Could be useful for Intel and AMD GPUs.

A better solution would be to add Vendor Id detection instead,
but this will do for now.

To disable the Nvidia hack add UserHacks_DisableNVhack=1 in GSdx.ini

Issue #1026

GSdx: Add hidden option to disable Nvidia hack
Add hidden option "UserHacks_DisableNVhack" to disable
the Nvidia hack on Direct3D which added black lines on the right
and bottom of the screen. Could be useful for Intel and AMD GPUs.

A better solution would be to add Vendor Id detection instead,
but this will do for now.

To disable the Nvidia hack add UserHacks_DisableNVhack=1 in GSdx.ini
@mirh

This comment has been minimized.

Show comment
Hide comment
@mirh

mirh Nov 25, 2017

Mhhh..
Reminds me of this.

mirh commented Nov 25, 2017

Mhhh..
Reminds me of this.

@lightningterror

This comment has been minimized.

Show comment
Hide comment
@lightningterror

lightningterror Nov 25, 2017

Member

Just your typical driver bugs everywhere xD
Anyway I know that the sprite hack disables the nvidia hack but enabling it may cause other issues where games don't need that specific hack.

Member

lightningterror commented Nov 25, 2017

Just your typical driver bugs everywhere xD
Anyway I know that the sprite hack disables the nvidia hack but enabling it may cause other issues where games don't need that specific hack.

@mirh

This comment has been minimized.

Show comment
Hide comment
@mirh

mirh Nov 25, 2017

Well, idk.
I think it would be a good practice to keep a unified list of all the driver hacks though.

mirh commented Nov 25, 2017

Well, idk.
I think it would be a good practice to keep a unified list of all the driver hacks though.

@ssakash

This comment has been minimized.

Show comment
Hide comment
@ssakash

ssakash Nov 29, 2017

Member

Looks good to me, always handy to have a hidden option to check if the hack is needed or not instead of manually changing the code and compiling it every time a new driver comes up.

By the way, your vendor ID suggestion also seems good. You can add it to this PR if you want.

Member

ssakash commented Nov 29, 2017

Looks good to me, always handy to have a hidden option to check if the hack is needed or not instead of manually changing the code and compiling it every time a new driver comes up.

By the way, your vendor ID suggestion also seems good. You can add it to this PR if you want.

@lightningterror

This comment has been minimized.

Show comment
Hide comment
@lightningterror

lightningterror Nov 29, 2017

Member

By the way, your vendor ID suggestion also seems good. You can add it to this PR if you want.

I'll need your help with that 😄

Member

lightningterror commented Nov 29, 2017

By the way, your vendor ID suggestion also seems good. You can add it to this PR if you want.

I'll need your help with that 😄

@ssakash

This comment has been minimized.

Show comment
Hide comment
@ssakash

ssakash Nov 29, 2017

Member

Look into #1795 for reference.

Member

ssakash commented Nov 29, 2017

Look into #1795 for reference.

@lightningterror

This comment has been minimized.

Show comment
Hide comment
@lightningterror

lightningterror Dec 4, 2017

Member

You can merge it as it is now, I'll look in to improving the conditions how it works another time in the future :)

Member

lightningterror commented Dec 4, 2017

You can merge it as it is now, I'll look in to improving the conditions how it works another time in the future :)

@@ -58,6 +58,7 @@ class GSDevice11 : public GSDeviceDX
bool isNative;
bool UserHacks_unscale_pt_ln;
bool UserHacks_disable_NV_hack;

This comment has been minimized.

@ssakash

ssakash Dec 10, 2017

Member

I'm not sure how this style of not using m_ prefix for member variables got introduced, but I'm merging this for now as this style seems to be present for most of the variables on this class.

@ssakash

ssakash Dec 10, 2017

Member

I'm not sure how this style of not using m_ prefix for member variables got introduced, but I'm merging this for now as this style seems to be present for most of the variables on this class.

@ssakash ssakash merged commit 41051f3 into PCSX2:master Dec 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lightningterror lightningterror deleted the lightningterror:nvidia-hack branch Dec 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment