Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Counters: Fix Hblank calculation for DVD videmodes #2239
Summary of changes:
Using out of box settings, except PSX titles marked as needing IOP interpreter and I used OGL SW renderer for all. Used ISO mode. For reference, here was my test pool by system:
I just sort of threw out every "glaring" issue I've seen in PSX mode. Is there anything in particular I should be looking for?
The last time we got this wrong, it caused skippy FMV and out of sync issues in few games (#1368 (comment))
Thanks for all the tests by the way. :)
Not probably the accurate term but I just consider modes other than NTSC/PAL standard as digital video modes. I just use the classification between them to manage the timing code more accurately.
Not just rounding, there's also halving of the hblank and hrender in case of video modes other than NTSC/PAL, previously that was being applied while it shouldn't have been.
Sure, I'm happy with the patch for now, seems like it fixed an issue (mentioned in pandubz's post) and hasn't caused any regressions so far.
referenced this pull request
Jan 14, 2018
vSyncInfoCalc() is just so full of speculation, it's hard to tell if any later timing changes do the right thing.
Yea, I find that hard to believe. Even if the comment says that it's true. I just don't know how we can test for it.
Don't you thinks it's kind of interesting that you changed something as important as timing by a non-negligible change as dividing or multiplying some part of the calculation by two and there is no major change? Just assume you divide your FSB's or one of your RAM modules' clockrate by two...