New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCSX2: Add configurable Cheats folder to Components Selectors #2272

Merged
merged 1 commit into from Jan 27, 2018

Conversation

Projects
None yet
6 participants
@lightningterror
Member

lightningterror commented Jan 23, 2018

Add GUI option in the Plugins Component Selector to change the default "Cheats" folder location.
Similar to savestates/logs/..etc

This has been bugging me. I have no idea how many times I deleted my cheats folder by mistake when updating to newer dev builds. This should solve all those issues for many people.

image

Close #1584

@MrCK1

This comment has been minimized.

Member

MrCK1 commented Jan 23, 2018

Just wondering, how do you accidentally delete your cheats folder when upgrading dev builds? If it was backed up in a safe place, we wouldn't have to go through the trouble of changing all of the translatable strings again.

@lightningterror

This comment has been minimized.

Member

lightningterror commented Jan 23, 2018

Well since I have per game configs all of the files (bios, memory cards, .. etc) are located in documents, so when I purge the old version I delete everything and keep forgetting about the Cheats.

As for changing the translatable strings again well they need to be changed anyway when FlatOut's PR gets merged 😛

Edit: Plus this way it's easier to maintain, sometimes people get confused where to put the cheats either in documents or pcsx2 directory. This will make it easier for them.
Also this will allow to share the directory between versions (example 1.4 and 1.5)

@lightningterror lightningterror force-pushed the lightningterror:cheats-folder branch Jan 23, 2018

@lightningterror lightningterror changed the title from PCSX2: Add Cheats folder to Components Selector to PCSX2: Add configurable Cheats folder to Components Selectors Jan 23, 2018

@mirh

This comment has been minimized.

mirh commented Jan 23, 2018

I wonder if all those options couldn't be moved under a single "stuff" path?

@FlatOutPS2

This comment has been minimized.

Member

FlatOutPS2 commented Jan 23, 2018

I wonder if all those options couldn't be moved under a single "stuff" path?

That would not be a good idea. Someone could have, say, a global cheats folder somewhere outside of the PCSX2 folder, while using the default paths for all other folders. Although adding a global option that affects all folders instead of having to modify all of 'em separately(folder options for bios/mc/plugins are all located elsewhere in the UI) when you do have all folders in the same location could be helpful.

pcsx2/gui/Panels/PathsPanel.cpp Outdated
*this += (new DirPickerPanel( this, FolderId_Cheats,
_("Cheats:"),
_("Select folder for Cheats") ))->
SetToolTip( pxEt( L"This folder is where PCSX2 custom cheats can be stored."

This comment has been minimized.

@turtleli

turtleli Jan 23, 2018

Member

Maybe

This folder is where PCSX2 searches for cheats.

or

This folder is where PCSX2 loads cheats from.

would be better?

This comment has been minimized.

@lightningterror

lightningterror Jan 23, 2018

Member

I'll go with the second one.

PCSX2: Add configurable Cheats folder to Components Selectors.
Add GUI option to Plugins Components Selectors to change the default
"Cheats" folder location. Similar to savestates/logs/..etc.

@lightningterror lightningterror force-pushed the lightningterror:cheats-folder branch to 4d0cacc Jan 23, 2018

@lightningterror

This comment has been minimized.

Member

lightningterror commented Jan 27, 2018

@turtleli do you wanna merge this ?

@turtleli

This comment has been minimized.

Member

turtleli commented Jan 27, 2018

Well, you assigned ssakash so I figured you wanted him to review your PR?

@lightningterror

This comment has been minimized.

Member

lightningterror commented Jan 27, 2018

Ye since he's usually the one that does gui updates but seems he's a bit busy these days.
Tho you also reviewed it :P

@turtleli turtleli merged commit ab44ebd into PCSX2:master Jan 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lightningterror lightningterror deleted the lightningterror:cheats-folder branch Jan 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment