New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx: Add/adjust more CRC ids, remove GT3/Concept CRC hacks, cleanup hacks in GSRendererHW #2335

Merged
merged 3 commits into from Mar 13, 2018

Conversation

Projects
None yet
4 participants
@lightningterror
Member

lightningterror commented Mar 8, 2018

GSdx: Remove GT3/Concept CRC Hacks.
The CRC hacks are no longer needed due to the partial port of channel
shuffle on D3D.
They cause higher vram spikes now.

GSdx: Add/adjust CRC ids.
Add some missing regions: Tomb Raider Legend JP,
StarWars Force Unleashed EU, SuperMan Returns EU, Valkyrie Profile 2 FR.
Rename GT3/Concept titles, they were incorrect.
Adjust Harley Davidson region id from NoRegion to US.
Add some missing regions to automatic mipmapping:
FIFA 03 US, FIFA 04 EU, FIFA 05 EU.
Reformat a few comments.

GSdx: Cleanup hacks in GSRendererHW.
Merge identical code for Spyro Games in to one to avoid duplicate code.
Rename hacks name for Jak series from OO_Jak to OO_JakGames since there
are multiple games added.

@lightningterror lightningterror force-pushed the lightningterror:morecrcids branch Mar 8, 2018

@ssakash

This comment has been minimized.

Member

ssakash commented Mar 8, 2018

@turtleli

Is it fine to separate minor format changes into a separate commit? (1f3eef5)

Personally I think it's good when there are lots of formatting changes being done but I'm not sure if it's optimal to have a separate commit specifically for it when the change is rather small. I recall you having a strong stance on favouring this, so pinging you for your opinion regarding the matter.

@FlatOutPS2

This comment has been minimized.

Member

FlatOutPS2 commented Mar 8, 2018

Add missing regions for FIFA03,04,05 series to Automatic Mipmapping.

You might want to word this more specifically as Add some missing regions..., as there are still regions missing. The same likely goes for some of the other games as well.

@lightningterror lightningterror force-pushed the lightningterror:morecrcids branch Mar 8, 2018

@turtleli

This comment has been minimized.

Member

turtleli commented Mar 9, 2018

@ssakash I don't recall having a strong stance for small non-functional changes? I guess the same reasoning for having larger non-functional changes in a separate commit still applies to smaller changes, though it's not as important. In this case though it's only changing the comments in very minor ways.

@lightningterror

This comment has been minimized.

Member

lightningterror commented Mar 9, 2018

I'll merge the two commits then.

lightningterror added some commits Mar 7, 2018

GSdx: Add/adjust CRC ids.
This follows PR #2330.

Add some missing regions: Tomb Raider Legend JP,
StarWars Force Unleashed EU, SuperMan Returns EU, Valkyrie Profile 2 FR.

Rename GT3/Concept titles, they were incorrect.

Adjust Harley Davidson region id from NoRegion to US.

Add some missing regions to automatic mipmapping:
FIFA 03 US, FIFA 04 EU, FIFA 05 EU.

Reformat a few comments.
GSdx: Remove GT3/Concept CRC Hacks.
This follows PR #2304.
The CRC hacks are no longer needed due to the partial port of channel
shuffle on D3D.
They cause higher vram spikes  now.

@lightningterror lightningterror force-pushed the lightningterror:morecrcids branch to 5b5f870 Mar 9, 2018

@lightningterror lightningterror changed the title from GSdx: Add/adjust more CRC ids, remove GT3/Concept CRC hacks to GSdx: Add/adjust more CRC ids, remove GT3/Concept CRC hacks, cleanup hacks in GSRendererHW Mar 9, 2018

GSdx: Cleanup hacks in GSRendererHW.
Merge identical code for Spyro Games in to one to avoid duplicate code.

Rename hacks name for Jak series from OO_Jak to OO_JakGames since there
are multiple games added.

@lightningterror lightningterror force-pushed the lightningterror:morecrcids branch to 73c0086 Mar 9, 2018

@ssakash ssakash merged commit 6aaae69 into PCSX2:master Mar 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lightningterror lightningterror deleted the lightningterror:morecrcids branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment