New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx: Adjust Fbmask and CRC hacks #2350

Merged
merged 3 commits into from Mar 27, 2018

Conversation

Projects
None yet
3 participants
@lightningterror
Member

lightningterror commented Mar 25, 2018

GSdx: Remove fbmask handle in GSRendererDX.
It's already handled in texture shuffle code.

GSdx: Adjust CRC hacks.
Move CRC hack for ICO that removed shadows to Aggressive, shadows are misaligned
when upscaling - can be fixed with HPO. We can use the hack as a speedhack
for Aggressive state.

Add correct FBP code for Sly 2 E3 Demo. CRC hack should work properly now.

Purge God of War 1/2 CRC hacks that fixed/removed the vertical red lines.
No longer needed since the issue is fixed accross all renders.
Also useless to be kept for speedhacks.

GSdx: Add Quak3 Revolution to Automatic mipmapping.

GSdx: Remove fbmask handle in GSRendererDX.
It's already handled in texture shuffle code.

@lightningterror lightningterror force-pushed the lightningterror:HLE-ICO branch Mar 25, 2018

@refractionpcsx2

This comment has been minimized.

Member

refractionpcsx2 commented Mar 26, 2018

You're going to be the new gregory at this rate. People are gonna start hassling you for Vulkan renderers :P

@lightningterror

This comment has been minimized.

Member

lightningterror commented Mar 26, 2018

I can't take all the credit, Gregory explained to me how the code works and which to remove 😋

When in doubt asks Gregory

@refractionpcsx2

This comment has been minimized.

Member

refractionpcsx2 commented Mar 26, 2018

Yeah but you're beginning to understand it, that's more than the rest of the team :P

@lightningterror lightningterror changed the title from GSdx: Adjust Fbmask and ICO crc hacks. to GSdx: Adjust Fbmask and ICO crc hacks Mar 26, 2018

@gregory38

This comment has been minimized.

Contributor

gregory38 commented Mar 26, 2018

@MrCK1 , @lightningterror Did you test this new change on texture shuffle game ?

@lightningterror

This comment has been minimized.

Member

lightningterror commented Mar 26, 2018

MGS3, Final Fight Streetwise, Urban Chaos, Stolen, The suffering tested. Everything seems to be working fine, no regressions or extra fixes.

Also tested gs dumps from The Godfather, 50 cent Bulletproof.

Everything works like before/same result on master.

@gregory38

This comment has been minimized.

Contributor

gregory38 commented Mar 26, 2018

I'm surprised there isn't any impact. If you have it, you could also check God of War. There are multiple effects on the initial ship.

@lightningterror

This comment has been minimized.

Member

lightningterror commented Mar 26, 2018

First image was from the PR I think, I dunno I can't notice any difference, the only thing that it seems to lack is depth support.

Note: Testing was done with crc level none.

pcsx2 2018-03-26 14-19-45-58

pcsx2 2018-03-26 14-20-03-56

@lightningterror lightningterror force-pushed the lightningterror:HLE-ICO branch Mar 26, 2018

@lightningterror lightningterror changed the title from GSdx: Adjust Fbmask and ICO crc hacks to GSdx: Adjust Fbmask and ICO / Sly 2 crc hacks Mar 26, 2018

GSdx: Adjust CRC hacks.
Move CRC hack that removed shadows to Aggressive, shadows are misaligned
when upscaling - can be fixed with HPO. We can use the hack as a
speedhack for Aggressive state.

Add correct FBP code for Sly 2 E3 Demo. CRC hack should work properly now.

Purge God of War 1/2 CRC hacks that fixed/removed the vertical red lines.
No longer needed since the issue is fixed accross all renders.
Also useless to be kept for speedhacks.

@lightningterror lightningterror force-pushed the lightningterror:HLE-ICO branch to 2a4c069 Mar 26, 2018

@lightningterror lightningterror changed the title from GSdx: Adjust Fbmask and ICO / Sly 2 crc hacks to GSdx: Adjust Fbmask and CRC hacks Mar 26, 2018

@lightningterror

This comment has been minimized.

Member

lightningterror commented Mar 27, 2018

You can merge it, I'm done making changes to it.

@gregory38 gregory38 merged commit 014e27b into PCSX2:master Mar 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lightningterror

This comment has been minimized.

Member

lightningterror commented Mar 27, 2018

Adjust CRC hacks. Move CRC hack that removed shadows to Aggressive, shadows are misaligned when upscaling - can be fixed with HPO.

Forgot to mention it's ICO, guess I didn't notice it. Thought I'd post it here for future reference, may come in handy.

@lightningterror lightningterror deleted the lightningterror:HLE-ICO branch Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment