Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx: GPU accelerate 8 bits texture conversion port from OpenGL to Direct3D11 #2590

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
3 participants
@lightningterror
Copy link
Member

commented Sep 12, 2018

Commit:
d29e375

Only native res is supported currently, but it's still great progress.
Someone needs to port the ScalingFactor to D3D from commit:
6121677

Credits to @KrossX for porting the shader.

@lightningterror lightningterror force-pushed the lightningterror:8bit-shader branch from 07e2f08 to 434820a Sep 12, 2018

@lightningterror lightningterror changed the title GSdx: GPU accelerate 8 bits texture conversion port from OpenGL to Direct3D. GSdx: GPU accelerate 8 bits texture conversion port from OpenGL to Direct3D Sep 12, 2018

@lightningterror lightningterror changed the title GSdx: GPU accelerate 8 bits texture conversion port from OpenGL to Direct3D GSdx: GPU accelerate 8 bits texture conversion port from OpenGL to Direct3D11 Sep 12, 2018

@lightningterror

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2018

I'm not sure if the dummy shaders are correct this way.

@lightningterror

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2018

Note for self > maybe this can be added after

theApp.LoadResource(IDR_CONVERT_FX, shader);

	// Scalingfactor
	ConvertConstantBuffer cb;

	cb.ScalingFactor = GSVector4i(theApp.GetConfigI("upscale_multiplier"));

	memset(&bd, 0, sizeof(bd));

	bd.ByteWidth = sizeof(ConvertConstantBuffer);
	bd.Usage = D3D11_USAGE_DEFAULT;
	bd.BindFlags = D3D11_BIND_CONSTANT_BUFFER;

	hr = m_dev->CreateBuffer(&bd, NULL, &m_convert.cb);
	// End Scalingfactor
// 2: 8 G | 8 A
// 3: 8 G | 8 A
float c;

This comment has been minimized.

Copy link
@turtleli

turtleli Sep 12, 2018

Member

Trailing whitespace here and a few other places too.

@lightningterror lightningterror force-pushed the lightningterror:8bit-shader branch 3 times, most recently from 8e0eedc to 3f9101c Sep 13, 2018

@lightningterror

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2018

@turtleli what about the dummy shaders ? Are they fine like that ?

@lightningterror lightningterror force-pushed the lightningterror:8bit-shader branch from 3f9101c to 4b1e96a Sep 13, 2018

GSdx: GPU accelerate 8 bits texture conversion port from OpenGL to Di…
…rect3D11.

Commit:
d29e375

Only native res is supported currently, but it's still great progress.
Someone needs to port the ScalingFactor to D3D from commit:
6121677

Credits to KrossX for porting the shader.

@lightningterror lightningterror force-pushed the lightningterror:8bit-shader branch from 4b1e96a to 8d93587 Sep 13, 2018

@lightningterror

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2018

Updated the dummy shaders, now they work properly with the help of refraction.

Anyway the results are quite good, there's basically 0 speed penalty with the shader.
Blood Will Tell looks awesome on native.

beforeafter_8bitshader_2

I'll be merging this since it works properly.

@lightningterror lightningterror merged commit f40c1de into PCSX2:master Sep 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lightningterror lightningterror deleted the lightningterror:8bit-shader branch Sep 13, 2018

@lightningterror lightningterror added this to the Release 1.6 milestone Sep 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.