Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx-ogl: Implement a fast Accurate Date algorithm #2718

Merged
merged 2 commits into from Nov 28, 2018

Conversation

Projects
None yet
2 participants
@lightningterror
Copy link
Member

commented Nov 27, 2018

Suggested by @gregory38
Change the checkbox to a drop down list Off, Fast, Full.
Off and Full do the same as before, the Fast option is new. Most of the
time users don't actually need full Accurate Date so why not reduce that
cost and use a fast mode instead, plus it can also be used on a gpu with
a limited driver. Also change the default value to Fast instead of Off.

image

Fixes #2068

@lightningterror lightningterror force-pushed the lightningterror:date-gt4issue branch from fe0b4cb to dc113c3 Nov 27, 2018

@lightningterror

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2018

I moved around some stuff on linux to better match windows gui.

@lightningterror lightningterror force-pushed the lightningterror:date-gt4issue branch 5 times, most recently from 788a3c1 to ea3411a Nov 28, 2018

@lightningterror

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2018

I made some final adjustments so it should be ready to go.
@gregory38 I think you'll be happy with Full Accurate DATE, Fast Accurate DATE, and Inaccurate DATE logs :)

@lightningterror lightningterror force-pushed the lightningterror:date-gt4issue branch 3 times, most recently from cca52a5 to 2ef4886 Nov 28, 2018

lightningterror added some commits Nov 27, 2018

GSdx-ogl: Implement a fast Accurate Date algorithm.
Suggested by Gregory.
Change the checkbox to a drop down list Off, Fast, Full.
Off and Full do the same as before, the Fast option is new. Most of the
time users don't actually need full Accurate Date so why not reduce that
cost and use a fast mode instead, plus it can also be used on a gpu with
a limited driver. Also change the default value to Fast instead of Off.
GSdx-gtk: Move around some options to better match windows gui.
Move Enable User Hacks at the top. Otherwise spacing looks weird.
Large Framebuffer should be next to Allow 8 bit textures.
Move Accurate Date and Accurate Blending at the bottom (similar to windows).

@lightningterror lightningterror force-pushed the lightningterror:date-gt4issue branch from 2ef4886 to e2e003c Nov 28, 2018

@lightningterror

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2018

I did a final check and the option works fine, tooltips seem good as well, as for adding a tooltop on the label I won't do that because if we do one we gotta do all and I'd rather if we keep things consistent.

On a final note this is how the gui looks under linux:
image

And Windows:
image

Let's merge it and let others play around with the setting. :)
I'm done nitpicking small details.

@lightningterror lightningterror merged commit f183ca1 into PCSX2:master Nov 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lightningterror lightningterror deleted the lightningterror:date-gt4issue branch Nov 28, 2018

@orbea

This comment has been minimized.

Copy link
Contributor

commented Nov 29, 2018

@lightningterror Just out of curiosity, what would be some cases where Fast is not enough and Full is required?

@lightningterror

This comment has been minimized.

Copy link
Member Author

commented Nov 29, 2018

Accurate Date solves transparency/shadow issues. So for example if Fast mode doesn't solve it your next step is to try Full mode. I haven't encountered a game so far where Fast is not enough. Full is more accurate.

@orbea

This comment has been minimized.

Copy link
Contributor

commented Nov 29, 2018

Okay, that helps explain, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.