Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx-d3d: Partial port for DATE one (Fast Date) and Fast Accurate Date #2723

Merged
merged 2 commits into from Nov 29, 2018

Conversation

Projects
None yet
2 participants
@lightningterror
Copy link
Member

commented Nov 28, 2018

It fixes a bunch of shadow/transparency issues.
Fast DATE doesn't rely on the gui option and is always on.
Confirmed fixed issues: Persona 3 shadows on d3d11,
Digital Devil Saga Transparency d3d9/11.

Fast accurate date works the same/similar to OpenGL.
Confirmed fixed issues: DBZ BT3 ground shadows, Fifa Street 1 shadows
on all d3d renders as well.

Also this option doesn't cause other transparency issues like the
Alpha Stencil hack.

Note: If Alpha Stencil is enabled Fast Date and Fast Accurate Date will
be disabled.

Note2: Full Accurate Date is not implemented so the code fallbacks to
Fast mode instead.

Commits:
3ab12ce
584397a

This will probably be the last feature d3d9 gets before getting purged.

@lightningterror lightningterror force-pushed the lightningterror:dateone-dx branch 2 times, most recently from 0d86d3f to 85f0cf5 Nov 29, 2018

GSdx-d3d: Partial port for DATE one (Fast Date) and Fast Accurate Date.
It fixes a bunch of shadow/transparency issues.
Fast DATE doesn't rely on the gui option and is always on.
Confirmed fixed issues: Persona 3 shadows on d3d11,
Digital Devil Saga Transparency d3d9/11.

Fast accurate date works the same/similar to OpenGL.
Confirmed fixed issues: DBZ BT3 ground shadows, Fifa Street 1 shadows
on all d3d renders as well.

Also this option doesn't cause other transparency issues like the
Alpha Stencil hack.

Note: If Alpha Stencil is enabled Fast Date and Fast Accurate Date will
be disabled.

Note2: Full Accurate Date is not implemented so the code fallbacks to
Fast mode instead.

Commits:
3ab12ce
584397a

This will probably be the last feature d3d9 gets before getting purged.

@lightningterror lightningterror force-pushed the lightningterror:dateone-dx branch from 7601911 to 74df49d Nov 29, 2018

@lightningterror lightningterror force-pushed the lightningterror:dateone-dx branch from 74df49d to 5a156c8 Nov 29, 2018

@lightningterror lightningterror merged commit f687f99 into PCSX2:master Nov 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lightningterror

This comment has been minimized.

Copy link
Member Author

commented Nov 29, 2018

Ok let's merge this. The games I tested and the dumps from Gregory indicate that everything seems to be working peachy. Games that utilize fast DATE or fast accurate DATE look the same as gl.

Time for the rest of the users to dig up on the early Christmas presents.

@lightningterror lightningterror deleted the lightningterror:dateone-dx branch Nov 29, 2018

@MrCK1

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

Crappy AMD joke was here :P

@lightningterror lightningterror added this to the Release 1.6 milestone Nov 29, 2018

@lightningterror

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2018

A small correction in the testing info. It barely works on dx9, it's the same with Alpha Correction but I guess nobody cares about dx9 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.