Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx-d3d: Add support for Depth Conversion on Direct3D11 #2734

Merged
merged 7 commits into from Dec 9, 2018

Conversation

Projects
None yet
4 participants
@lightningterror
Copy link
Member

commented Dec 4, 2018

Code is ported from OpenGL.
Note: Depth fmt is still not yet supported but after this has been merged it should be a lot easier to do.

Collaborators: @KrossX , @tadanokojin , @gregory38

@lightningterror lightningterror force-pushed the lightningterror:convert-depth branch 2 times, most recently from 5ce9e16 to da35a91 Dec 4, 2018

@lightningterror lightningterror added this to the Release 1.6 milestone Dec 4, 2018

@lightningterror lightningterror requested a review from turtleli Dec 6, 2018

@gregory38
Copy link
Contributor

left a comment

Please find my review with various small comments.

Show resolved Hide resolved plugins/GSdx/res/convert.fx Outdated
Show resolved Hide resolved plugins/GSdx/res/convert.fx Outdated
Show resolved Hide resolved plugins/GSdx/Renderers/DX11/GSTextureCache11.cpp Outdated
Show resolved Hide resolved plugins/GSdx/Renderers/DXCommon/GSRendererDX.cpp Outdated
Show resolved Hide resolved plugins/GSdx/Renderers/DX11/GSDevice11.cpp Outdated
Show resolved Hide resolved plugins/GSdx/Renderers/HW/GSRendererHW.cpp
Show resolved Hide resolved plugins/GSdx/Renderers/DX11/GSTexture11.cpp
convert.fx port main10-16 shaders from Opengl to Direct3d11.
Adds support to do depth conversion through the shaders.

@lightningterror lightningterror force-pushed the lightningterror:convert-depth branch 3 times, most recently from 0874dd5 to 1d70e36 Dec 9, 2018

@gregory38

This comment has been minimized.

Copy link
Contributor

commented Dec 9, 2018

It is fine for me (minus 2 nitpicks). It would be nice if it could be reviewed by others people too

lightningterror and others added some commits Dec 3, 2018

GSdx-TC11: Add support for depth formats in Direct3D11 Texture Cache.
Add depth formats for Direct3D11 to properly support depth.
Gsdx-d3d: Allow Direct3D11 to skip psm.depth on texture sampler.
depth fmt is not yet supported. This ensures there are no regressions,
and we are skipping the draw calls for depth fmt not yet supported.
GSdx-d3d: Add support to write in depth buffer.
Add support for dss_write.
Enable writing in depth buffer for dss_write,
when depth conversion is active data will be writen in the depth buffer,
if not then use the old method (don't write).
GSdx-d3d: Support depth as texture.
- Create depth as typeless format and bind shader resource flag.
- Create depth and shader resource view using proper typed formats.

@lightningterror lightningterror force-pushed the lightningterror:convert-depth branch from 1d70e36 to db3a7f3 Dec 9, 2018

@lightningterror

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2018

It would be nice if it could be reviewed by others people too

You are the chosen one 😛
Anyway I took care of the nitpicks as well, I'll go ahead and merge it since all requests/issues have been taken care of. Maybe turtleli can re check the pr just to make sure but I think it's fine.

Time to let normal users enjoy the new goodies.

@lightningterror lightningterror merged commit ecbd8d9 into PCSX2:master Dec 9, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@lightningterror lightningterror deleted the lightningterror:convert-depth branch Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.