Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx: OSD Enhancements v2 #2752

Merged
merged 12 commits into from Dec 20, 2018

Conversation

Projects
None yet
6 participants
@tadanokojin
Copy link
Member

commented Dec 14, 2018

Continued from #2730

OGL OSD ported to DX11 along with the other features present in the previous PR.

DX11
002020

OGL
002021

Config:
002022

Fixes #1585

@lightningterror lightningterror added this to the Release 1.6 milestone Dec 14, 2018

@lightningterror lightningterror changed the title GSdx: OSD Part 2 GSdx: OSD Enhancements v2 Dec 14, 2018

@tadanokojin tadanokojin force-pushed the tadanokojin:osd-v2 branch from f810c3f to 5b5116a Dec 14, 2018

@Blackbird88

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2018

How are you even supposed to change the font? It never worked for me.

@tadanokojin tadanokojin force-pushed the tadanokojin:osd-v2 branch from 5b5116a to 3848d0e Dec 14, 2018

@tadanokojin tadanokojin force-pushed the tadanokojin:osd-v2 branch 2 times, most recently from 488b654 to 622aaa7 Dec 16, 2018

tadanokojin and others added some commits Dec 14, 2018

gsdx-osd: Update manager to support DX11
Fix an issue with w coordinate values being 0 which caused issues on DX11.
convert.fx: Add color support to IA
Support color input in vs and ps.
Skipping dx9.
gsdx-osd: Rename log speed to log timeout
Linux/Windows GUI to be updated in later commits.
gsdx-osd: Switch to opacity
Switch to using opacity since this is how most software works.
Transparency is simply confusing to the average user.

Linux/Windows GUI to be updated in later commits.
gsdx-osd: Scale based on window size
Switch to scaling on the window size instead of a hardcoded monitor res

@tadanokojin tadanokojin force-pushed the tadanokojin:osd-v2 branch from 622aaa7 to f8cdf74 Dec 20, 2018

tadanokojin and others added some commits Dec 12, 2018

gsdx-osd: Update osd gui
Add support for color picker, remove font selector, enable the menu for dx11 and some other tweaks.
gsdx-osd: Update Linux dialog
Update linux dialog to match Windows.
Only color is missing.

@tadanokojin tadanokojin force-pushed the tadanokojin:osd-v2 branch from f8cdf74 to 3ac675f Dec 20, 2018

@lightningterror lightningterror merged commit e51eada into PCSX2:master Dec 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tadanokojin tadanokojin deleted the tadanokojin:osd-v2 branch Dec 26, 2018

@JasonBrownDeveloper

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

Was there a reason you removed the color argument from the API? The colors were supposed to match the messages in the log. I'm not trying to nitpick or complain. I know there was some concern previously about the colors potentially blending in to a background.

@tadanokojin

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

@JasonBrownDeveloper it seemed better to give people the option of color. For me personally, I felt the colors were dark and it's not really a common case you get an error or warning. It might be possible though, perhaps in the future we can override the user color when warning/error is displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.