Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx-d3d11: Detect FB read on Slot 4 #2754

Merged
merged 6 commits into from Dec 17, 2018

Conversation

Projects
None yet
4 participants
@tadanokojin
Copy link
Member

commented Dec 16, 2018

Check for FB read on slot 4.
If it happens, copy the render target and replace slot 4.

This is useful for properly emulating the channel shuffle effect on dx11.

Much thanks to @gregory38 for his help on this.

@tadanokojin tadanokojin force-pushed the tadanokojin:gsdx-chan-shuffle-copy branch 2 times, most recently from b731a15 to ee76b94 Dec 16, 2018

@lightningterror lightningterror added this to the Release 1.6 milestone Dec 16, 2018

@tadanokojin tadanokojin force-pushed the tadanokojin:gsdx-chan-shuffle-copy branch from ee76b94 to ac663f6 Dec 16, 2018

@AlessandroVetere
Copy link
Contributor

left a comment

I found just some code formatting details to be adjusted.

Show resolved Hide resolved plugins/GSdx/Renderers/DX11/GSDevice11.cpp Outdated
Show resolved Hide resolved plugins/GSdx/Renderers/DX11/GSTexture11.h Outdated
Show resolved Hide resolved plugins/GSdx/Renderers/DX11/GSDevice11.h Outdated

@tadanokojin tadanokojin force-pushed the tadanokojin:gsdx-chan-shuffle-copy branch from ac663f6 to e448e17 Dec 16, 2018

@tadanokojin tadanokojin force-pushed the tadanokojin:gsdx-chan-shuffle-copy branch from e448e17 to 650a96d Dec 17, 2018

@tadanokojin

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2018

@AlessandroVetere pointer syntax should be sorted now.

@lightningterror

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

I gave it a quick test just now and it works.

@gregory38

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2018

It is fine for me.

@lightningterror

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

Ok let's merge it, will add the rest of the channel shuffle code after this.

@lightningterror lightningterror merged commit ef0ebd6 into PCSX2:master Dec 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tadanokojin tadanokojin deleted the tadanokojin:gsdx-chan-shuffle-copy branch Dec 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.