Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CDVDpeops and PeopsSPU2. #2792

Merged
merged 1 commit into from Jan 4, 2019
Merged

Remove CDVDpeops and PeopsSPU2. #2792

merged 1 commit into from Jan 4, 2019

Conversation

arcum42
Copy link
Contributor

@arcum42 arcum42 commented Dec 31, 2018

On checking, CDVDpeops and PeopsSPU2 were not in either the main or old plugin solution on the windows side, and neither were in the cmake build system on the Linux side, either.

As such, both seem safe candidates for deletion.

I also removed a few references to plugins that aren't actually in the trunk any more, as well.

Copy link
Member

@ramapcsx2 ramapcsx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These old plugins are for reference / archival.
They shouldn't be referenced anywhere anymore, so if you found and removed references, that's good :)

I think a full removal is okay at this point.

@arcum42
Copy link
Contributor Author

arcum42 commented Jan 4, 2019

No time like the present, then. We can always look back on the branches for previous releases is we need to reference them. ^_^

@arcum42 arcum42 merged commit c58acd1 into master Jan 4, 2019
@arcum42 arcum42 deleted the no-peops branch January 4, 2019 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants