Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx-d3d11: Remove old colclip algo and add support for HDR colclip #2807

Merged
merged 4 commits into from Jan 12, 2019

Conversation

Projects
None yet
2 participants
@lightningterror
Copy link
Member

commented Jan 11, 2019

Remove colclip and negative blend algo.
Code was old and inefficient. HDR colclip will do a better job.

GSdx-d3d11: Add/port HDR colclip support.
It helps render shadows a lot better compared to the old code.

convert.fx: Update main4 shader to better support hdr colclip.

Credits to @gregory38 and @tadanokojin for helping with the code.

@lightningterror lightningterror force-pushed the lightningterror:colclip-hdr branch from 7d67823 to 59489b7 Jan 11, 2019

@lightningterror lightningterror changed the title GSdx-d3d11: Remove old colclip aldo and add support for HDR colclip GSdx-d3d11: Remove old colclip algo and add support for HDR colclip Jan 12, 2019

@gregory38

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2019

A test of sotc would be nice. Probably only game where old algo was fine

@gregory38

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2019

  • the minor comment it could be merged

lightningterror added some commits Jan 10, 2019

GSdx-d3d11: Remove colclip and negative blend algo.
Code was old and inefficient. HDR colclip will do a better job.
GSdx-d3d11: Add/port HDR colclip support.
It helps render shadows a lot better compared to the old code.

Credits to Gregory and Kojin for helping with the code.

@lightningterror lightningterror force-pushed the lightningterror:colclip-hdr branch from 59489b7 to d99b021 Jan 12, 2019

@lightningterror lightningterror force-pushed the lightningterror:colclip-hdr branch from d99b021 to 500979f Jan 12, 2019

GSdx: Move BoundingBox to HW render and update d3d11 code to use the …
…gl bounding box as well.

hdr colclip and date uses it.

@lightningterror lightningterror merged commit 7e6c325 into PCSX2:master Jan 12, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@lightningterror lightningterror deleted the lightningterror:colclip-hdr branch Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.