Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx-d3d11: Add partial support for frame buffer masking #2928

Merged
merged 4 commits into from Apr 22, 2019

Conversation

Projects
None yet
1 participant
@lightningterror
Copy link
Member

commented Apr 18, 2019

It works on games such as Fifa Street 1 and 2 (character and stage
rendering), mission impossible operation surma (shadow rendering).

Note: Frame buffer masking is only doable on alpha channel on d3d11
so the feature is not complete unlike on gl but it's a nice improvement overall.

Purge the old aout (Alpha hack) code since fbmask emulation will do a better accurate job.
Enable blending option on d3d to toggle fbmask emulation just like on opengl.
At least basic blending option is required to enable it.

lightningterror added some commits Apr 17, 2019

gsdx-d3d11: Remove old aout code.
Will be replaced with fbmask code in next commits.
gsdx-d3d11: Partial port of frame buffer masking from opengl.
It works on games such as Fifa Street 1 and 2 (character and stage
rendering), mission impossible operation surma (shadow rendering).
It needs at least Basic level of blending enabled on d3d11.
gsdx-gui: Purge the aout (Alpha hack) from the gui, will be useless w…
…ith fbmask emulation, enable blending option on d3d11.

Blending option allows us to toggle fbmask on or off with at least basic
level just like on gl.
gsdx-d3d11: Don't enable fbmask on triangle primitives.
It is quite slow due to fb copy on d3d, add potential notes for future
improvements so I don't forget what I wanted to do.

@lightningterror lightningterror force-pushed the fbmask-d3d branch from 5c67938 to 5ce9cb0 Apr 21, 2019

@lightningterror

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

Ok will merge the initial pr now, it's a lot better than what we currently have and it's a nice Easter present for D3D users :)
More improvements can be done afterwards, I have ideas for multiple blending levels for fbmask.

@lightningterror lightningterror merged commit 641df12 into master Apr 22, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lightningterror lightningterror deleted the fbmask-d3d branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.