Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx: WIP half bottom fix (Texture Shuffle Case) #2934

Merged
merged 5 commits into from Apr 25, 2019

Conversation

Projects
None yet
8 participants
@tadanokojin
Copy link
Member

commented Apr 21, 2019

No description provided.

@tadanokojin tadanokojin requested a review from gregory38 Apr 21, 2019

@legend800

This comment has been minimized.

Copy link

commented Apr 21, 2019

No change in Path of Neo. Darn, been waiting for this fix for years. :)

PR:
2019-04-21 09_32_26-Slot_ 0 _ Speed_ 100% (59 95) _ Limiter_ Normal _ GSdx OGL HW _ 2560x2240 _ Auto

Native Res.
2019-04-21 09_33_13-Slot_ 0 _ Speed_ 100% (60 01) _ Limiter_ Normal _ GSdx OGL SW _ 512x448 _ Automa

@MrCK1

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

Just remember it's only a WIP/Proof of Concept. Give it some time to improve, I wouldn't expect anything changes yet.

@tadanokojin tadanokojin force-pushed the tadanokojin:crash-depth branch from 2252e41 to c9f3c99 Apr 21, 2019

@tadanokojin tadanokojin force-pushed the tadanokojin:crash-depth branch 6 times, most recently from ac1b378 to fd0a7d3 Apr 22, 2019

@legend800

This comment has been minimized.

Copy link

commented Apr 22, 2019

Matrix - Path of Neo fixed on latest commit. Amazing work!

2019-04-22 08_21_33-Window

2019-04-22 08_25_19-Slot_ 0 _ Speed_ 100% (59 98) _ Limiter_ Normal _ GSdx OGL HW _ 2560x2240 _ Auto

@Silanda

This comment has been minimized.

Copy link

commented Apr 22, 2019

Need for Speed: Hot Pursuit 2's improved as well. The shadow on the road is gone, but the busted scenes are broken:

gsdx_20190422164046

@tadanokojin tadanokojin force-pushed the tadanokojin:crash-depth branch 4 times, most recently from 1314f1d to 5d92e22 Apr 22, 2019

@tadanokojin tadanokojin changed the title GSdx: WIP half bottom fix GSdx: WIP half bottom fix (Texture Shuffle Case) Apr 22, 2019

@tadanokojin

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

@Silanda was busted screen broken on master or is this new?
I updated the detection maybe it will fix it.

@Silanda

This comment has been minimized.

Copy link

commented Apr 22, 2019

@tadanokojin My bad. It looks like it may have been bust in master. I'd been playing in software mode and hadn't checked.

Also the change on line 452 of GSRendererHW.cpp from bool half_bottom = height_delta <= 5; to bool half_bottom = abs(height_delta) <= 5; causes the road graphics glitch to return.

@tadanokojin

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

Can you send a gsdump of the issue for me?
https://forums.pcsx2.net/Thread-How-to-create-a-proper-GS-dump

Couple of frames please.

@Silanda

This comment has been minimized.

Copy link

commented Apr 22, 2019

Here are a couple of single frame dumps from in game.
NFSHP2Dumps.zip

@gregory38 gregory38 referenced this pull request Apr 22, 2019

Open

Meta: GSdx HW half bottom screen issue #1339

18 of 61 tasks complete

@lightningterror lightningterror added this to the Release 1.6 milestone Apr 23, 2019

@tadanokojin tadanokojin force-pushed the tadanokojin:crash-depth branch 2 times, most recently from d12ea56 to e8cc85d Apr 23, 2019

@JOHN30011887

This comment has been minimized.

Copy link

commented Apr 23, 2019

How can i download this to test for crash twinsanity, sorry dont know what/where to click

@MrCK1

This comment has been minimized.

@tadanokojin

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

@Silanda it should be fixed

@Silanda

This comment has been minimized.

Copy link

commented Apr 23, 2019

Looks good here!

@JOHN30011887

This comment has been minimized.

Copy link

commented Apr 23, 2019

So i tested Crash Twinsanity since it was marked as fixed but sorry to be that guy but its not :(
It is alot better than what it was though, as before the top half of screen was yellow fog.

But now theres a yellow line where the bottom of the fog wall would be
pcsx2_2019_04_23_23_02_55_897

Doesnt make any difference on settings, happens in dx11 and opengl
only time it was gone was using ps2 resolution option, anything higher the solid yellow line appears again

@tadanokojin

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

@JOHN30011887 yes, it is an upscaling issue unrelated to half bottom issue. You can try maybe a TC offset.

@JOHN30011887

This comment has been minimized.

Copy link

commented Apr 23, 2019

oh, so half bottom issue is indeed fixed but now its another issue, ah ok then, thanks for info, il mess with that setting and see :)

I messed with the tc offset but no luck, increasing it to high numbers to hide the lines makes other textures really mess up so il just go back to waiting

@tadanokojin tadanokojin force-pushed the tadanokojin:crash-depth branch 2 times, most recently from 5820911 to cc966ad Apr 24, 2019

@tadanokojin

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

@JOHN30011887 how about half pixel offset special (texture - aggressive)

@JOHN30011887

This comment has been minimized.

Copy link

commented Apr 24, 2019

Tried that setting, the line is alot thiner so is harder to see but still there and also gives slight corruption to crash, he ends up with thin red lines on him when that setting in on texture - aggressive

@tadanokojin tadanokojin force-pushed the tadanokojin:crash-depth branch from 7e45d91 to eb92509 Apr 24, 2019

@Xcedf

This comment has been minimized.

Copy link

commented Apr 24, 2019

@JOHN30011887 use Half-pixel Offset Special (Texture-Aggressive) setting
See for youself
4xIR Normal-Vertex offset setting
47
Special-Texture
48
and Texture_Aggressive
49

@tadanokojin

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

EDIT: pardon. This thread is confusing now. Any chance we can move this discussion of crash?

@tadanokojin tadanokojin force-pushed the tadanokojin:crash-depth branch from eb92509 to 479f115 Apr 25, 2019

tadanokojin added some commits Apr 22, 2019

GSdx-hw: Add automatic detection of half-bottom in TS
Typical shuffle case is 1/2 height so other half is undesired

In dbz we split the depth buffer.
- Sample first half, write to `0x0`.
- Sample second half, write to `0x800`
- Finally, sample `0x0` though `0xffc`

Crash Twinsanity is a similar case.

@tadanokojin tadanokojin force-pushed the tadanokojin:crash-depth branch from 479f115 to 0150613 Apr 25, 2019

@lightningterror lightningterror merged commit 34ac15f into PCSX2:master Apr 25, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@denoid24

This comment has been minimized.

Copy link

commented Apr 29, 2019

Matrix - Path of Neo fixed on latest commit. Amazing work!

2019-04-22 08_21_33-Window

2019-04-22 08_25_19-Slot_ 0 _ Speed_ 100% (59 98) _ Limiter_ Normal _ GSdx OGL HW _ 2560x2240 _ Auto

Hey) i'm a new one noob here on github, please tell me how to apply the fix to my pcsx2) would be infinitely grateful for the help)

@tadanokojin

This comment has been minimized.

Copy link
Member Author

commented Apr 29, 2019

@denoid24
You don't need to apply it. You can download and setup a dev build.
Assisting you with that is not what this thread is for.

Please go to https://forums.pcsx2.net/ create an account and ask there if you need help.
Alternatively you can ask on discord.

@denoid24

This comment has been minimized.

Copy link

commented Apr 29, 2019

@denoid24

This comment has been minimized.

Copy link

commented Apr 29, 2019

@legend800

This comment was marked as spam.

Copy link

commented Apr 29, 2019

Stop spamming this PR. Take it to the forums to learn how to test pcsx2.

@PCSX2 PCSX2 locked and limited conversation to collaborators Apr 29, 2019

@tadanokojin tadanokojin deleted the tadanokojin:crash-depth branch Jul 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.