Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64-bit recompilers #3608

Merged
merged 9 commits into from Aug 24, 2020
Merged

64-bit recompilers #3608

merged 9 commits into from Aug 24, 2020

Conversation

@tellowkrinkle
Copy link
Member

@tellowkrinkle tellowkrinkle commented Aug 19, 2020

The main piece of #3451

Makes recompilers compatible with x86-64

@lightningterror
Copy link
Contributor

@lightningterror lightningterror commented Aug 19, 2020

Maybe some commits can be squashed and better named.

@tellowkrinkle tellowkrinkle force-pushed the tellowkrinkle:JIT64Clean branch 3 times, most recently from d54cd36 to de8b209 Aug 20, 2020
@tellowkrinkle
Copy link
Member Author

@tellowkrinkle tellowkrinkle commented Aug 20, 2020

How's that for squashing?

@lightningterror
Copy link
Contributor

@lightningterror lightningterror commented Aug 20, 2020

Yeah it's better, I'd name the commits better but it's fine.

@tellowkrinkle tellowkrinkle force-pushed the tellowkrinkle:JIT64Clean branch 8 times, most recently from e5c6e16 to 17b9ca3 Aug 20, 2020
@tellowkrinkle tellowkrinkle force-pushed the tellowkrinkle:JIT64Clean branch from ecc4fca to b7d5eb1 Aug 24, 2020
Successfully moved off of all of them
Required to build x86-64 correctly
@lightningterror lightningterror added this to the Release 1.8 milestone Aug 24, 2020
tellowkrinkle and others added 5 commits Jul 2, 2020
Use VEH instead of SEH on WIN64, as SEH needs us to register all our JIT functions for it
No longer says x86-64 breaks recompilers
Since x86-64 recompilers now work
If the C prototype says int, the compiler might leave garbage in the top half
It's supported now
@tellowkrinkle tellowkrinkle force-pushed the tellowkrinkle:JIT64Clean branch from b7d5eb1 to 3842990 Aug 24, 2020
@tellowkrinkle tellowkrinkle merged commit 91326e1 into PCSX2:master Aug 24, 2020
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@tellowkrinkle tellowkrinkle deleted the tellowkrinkle:JIT64Clean branch Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.