Skip to content

GS Include Cleanup#4709

Merged
TellowKrinkle merged 11 commits intoPCSX2:masterfrom
TellowKrinkle:GSIncludeCleanup
Nov 14, 2021
Merged

GS Include Cleanup#4709
TellowKrinkle merged 11 commits intoPCSX2:masterfrom
TellowKrinkle:GSIncludeCleanup

Conversation

@TellowKrinkle
Copy link
Copy Markdown
Member

Description of Changes

  • Move preprocessor macros to a header that's included by everything, to prevent accidents with ifdef
  • Remove custom countof macros in favor of std::size (or for-in loops / std::fill where applicable)
  • Replace GS's integer typedefs with the ones used by the rest of PCSX2 (uint32, int64u32, s64)
    • Note: A number of structs had conflicting members (e.g. GSVector4::u32), I fixed that by renaming those to use capital letters
  • Split GS.h into multiple smaller headers
  • Stop pretending GS.h is a PCH

Note: Builds upon #4708

Rationale behind Changes

  • Cleaner, more consistent code
  • Better compile times and less files recompiled per change in a header

Suggested Testing Steps

Make sure everything builds

@TellowKrinkle TellowKrinkle force-pushed the GSIncludeCleanup branch 4 times, most recently from 61eb0fc to 6bd3068 Compare November 3, 2021 03:33
@TellowKrinkle TellowKrinkle force-pushed the GSIncludeCleanup branch 4 times, most recently from 4d826cf to f926c7d Compare November 13, 2021 20:13
@TellowKrinkle TellowKrinkle merged commit 67299fc into PCSX2:master Nov 14, 2021
@TellowKrinkle TellowKrinkle deleted the GSIncludeCleanup branch November 14, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants