-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GS Include Cleanup #4709
Merged
Merged
GS Include Cleanup #4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcum42
reviewed
Sep 3, 2021
TellowKrinkle
force-pushed
the
GSIncludeCleanup
branch
from
September 5, 2021 01:14
bc7ce11
to
1965182
Compare
TellowKrinkle
force-pushed
the
GSIncludeCleanup
branch
from
September 5, 2021 02:16
1965182
to
ad3e9eb
Compare
Merged
seta-san
reviewed
Nov 1, 2021
TellowKrinkle
force-pushed
the
GSIncludeCleanup
branch
4 times, most recently
from
November 3, 2021 03:33
61eb0fc
to
6bd3068
Compare
TellowKrinkle
force-pushed
the
GSIncludeCleanup
branch
4 times, most recently
from
November 13, 2021 20:13
4d826cf
to
f926c7d
Compare
Less warnings about fastcall being unsupported, proper __assume implementation
Had to capitalize the names of some struct params that had the same names
TellowKrinkle
force-pushed
the
GSIncludeCleanup
branch
from
November 14, 2021 00:47
f926c7d
to
28f706f
Compare
Mrlinkwii
approved these changes
Nov 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
ifdef
std::size
(or for-in loops /std::fill
where applicable)uint32
,int64
→u32
,s64
)GSVector4::u32
), I fixed that by renaming those to use capital lettersGS.h
into multiple smaller headersGS.h
is a PCHNote: Builds upon #4708
Rationale behind Changes
Suggested Testing Steps
Make sure everything builds