SPU2: Disallow KeyOn within 2T of last KeyOn #4774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Legend of Spyro New Beginning hang
|
This PR does work fine in my set of games. It doesn't solve the "unknown TCTF" audio issue in Oni tho (first issue is pure EE timing issue). |
|
thanks for testing |
|
Edit, yeah, XGkick solve the issue I was having with your PR, + the fact that loading a savestate during bios loading triggers instant DMA is very good to falsify the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Disallow KeyOn less than 2T (768x2 cycles) of the previous KeyOn for a voice.
Fixes Legend of Spyro New Beginning hang
Rationale behind Changes
KeyOn/Off events shouldn't happen within 2T's of the last one for each voice (possibly the whole register, but unsure on that, per voice seems okay)
Suggested Testing Steps
uhh, any games you know had problems previously with delay cycles, that would be great.