Skip to content

Config: Fix folder memory cards initial load#4861

Merged
refractionpcsx2 merged 2 commits into
PCSX2:masterfrom
stenzek:memcards
Oct 3, 2021
Merged

Config: Fix folder memory cards initial load#4861
refractionpcsx2 merged 2 commits into
PCSX2:masterfrom
stenzek:memcards

Conversation

@stenzek
Copy link
Copy Markdown
Contributor

@stenzek stenzek commented Oct 2, 2021

Description of Changes

Fixed memory card folders being flagged as a non-present memory card if booting without opening the config dialog.

Also converted the type enum to a scoped enum, since I missed this in the other PR.

Rationale behind Changes

Regression from #4786.

Suggested Testing Steps

Make sure memory card folders load on a clean boot. I've checked it myself and they seem okay now.

Fixes #4862

@JordanTheToaster
Copy link
Copy Markdown
Member

Tested working in Windows but another problem seems to have appeared where if you change either aspect ratio or FMV aspect ratio override they will return to default values after a clean boot.

@lightningterror
Copy link
Copy Markdown
Contributor

Tested working in Windows but another problem seems to have appeared where if you change either aspect ratio or FMV aspect ratio override they will return to default values after a clean boot.

I informed Sten that aspect ratio, fmv aspect ratio, zoom (and maybe other stuff not yet discovered) don't work well on master, he'll look in to it tomorrow.

@JordanTheToaster
Copy link
Copy Markdown
Member

Tested working in Windows but another problem seems to have appeared where if you change either aspect ratio or FMV aspect ratio override they will return to default values after a clean boot.

I informed Sten that aspect ratio, fmv aspect ratio, zoom (and maybe other stuff not yet discovered) don't work well on master, he'll look in to it tomorrow.

Got it this is just the first time I've seen it crop up like this.

@lightningterror lightningterror added this to the Release 1.8 milestone Oct 2, 2021
@refractionpcsx2 refractionpcsx2 merged commit 1e70328 into PCSX2:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Folder based Memory Cards not detected properly

4 participants