gs-tc: propagate texture shuffle format on readback#4887
Merged
Conversation
Contributor
|
Great work. This also fixes Silent Hill shattered memories issue with flashlight and also shadows. |
Member
|
Ran through a bunch of games, didn't notice any new bugs/changes. |
Member
|
Wasn't sure what games this might fix (can't think of any with broken lighting/shadows off the top of my head), but I tested a bunch of games I know do GS downloads and they were all still peachy (except Star Wars Racer which is still broken, but probably outside the scope of this PR since it's depth download). so yeah, couldn't find anything else fixed I'm afraid, but also nothing broken, so LGTM |
lightningterror
changed the title
Contributor
|
Would be nice to adjust the commit prefix to |
lightningterror
approved these changes
Oct 8, 2021
lightningterror
left a comment
lightningterror
left a comment
Contributor
There was a problem hiding this comment.
Ran through the dump list which trigger the code, seemed fine.
tadanokojin
force-pushed
the
silent-hill
branch
from
929c16c to
9b8e211
Compare
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Read back PSMCT32 when the texture being blit is the result of a channel effect. This is not exactly right but there's no harm in having the extra data in cpu memory since it's supposed to be there anyway. The only issue is it gets unscaled.
fixes #1326
fixes #2732
Rationale behind Changes
Fixes silent hill flashlight.
Suggested Testing Steps
If you plan on testing silent hill, the game still needs fast texture invalidation.