Debugger: Support multi-line assembling#4926
Merged
refractionpcsx2 merged 1 commit intoPCSX2:masterfrom Oct 26, 2021
Merged
Conversation
F0bes
force-pushed
the
debugger-multiline-assemble
branch
2 times, most recently
from
a875a3a to
3a53489
Compare
F0bes
commented
Oct 21, 2021
| @@ -1,4 +1,4 @@ | |||
| /* PCSX2 - PS2 Emulator for PCs | |||
| /* PCSX2 - PS2 Emulator for PCs | |||
Member
Author
There was a problem hiding this comment.
I don't know what the difference is between these two lines, neither does my git client.
Contributor
There was a problem hiding this comment.
It has to be an invisible character maybe a missing carriage return byte or something?
Member
Author
There was a problem hiding this comment.
Weird, I'll try and fix it.
Contributor
There was a problem hiding this comment.
You already did. The fucked up characters were in master
Member
There was a problem hiding this comment.
That's a UTF-8 BOM
Some editors (I think VS) seem to use it to identify whether files are UTF-8 or not
F0bes
force-pushed
the
debugger-multiline-assemble
branch
from
3a53489 to
9b2e7b6
Compare
|
Seems to work great! |
|
|
||
| if (address == curAddress) | ||
| gotoAddress(manager.getNthNextAddress(curAddress, 1)); | ||
| if((selectRangeEnd - selectRangeStart) > 4) |
| gotoAddress(manager.getNthNextAddress(curAddress, 1)); | ||
| if((selectRangeEnd - selectRangeStart) > 4) | ||
| { | ||
| for(u32 addr = selectRangeStart; addr < selectRangeEnd; addr += 0x4) |
| } | ||
|
|
||
| setCurAddress(newAddress, extend); | ||
| if(setNewAddress) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
When multiple lines of opcodes are selected, the 'Assemble Opcode(s)' context menu and M-key shortcut will turn reassemble all of those opcodes.
Rationale behind Changes
Makes use of the multi line selection feature the debugger has.
Was also mentioned in a feature request #4889
Suggested Testing Steps
Try the assemble opcode feature in the debugger, see if it does it's job correctly.
Edit 1/2/3/etc opcodes and see if the result is okay.