DEV9: DNS Logger Crash fix#4940
Merged
Merged
Conversation
Mrlinkwii
approved these changes
Oct 28, 2021
JordanTheToaster
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Access the correct array for additional information when logging DNS packets
Rationale behind Changes
Was previously logging the wrong information for additional information.
If the DNS server does not include additional information, but did provide authorities information a crash would occur.
This wasn't picked up before as DNS logging is disabled by default.
Suggested Testing Steps
Set EthLogDNS to 1 in DEV9.cfg
Connect to an online server (via a online multiplayer game, or with the Network access disc)
Christian's DNS server (45.7.228.197) would crash the DNS logger in master, but gets logged correctly in this PR