Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS: Further state cleanup + fixes for older dump compatibility #4952

Merged
merged 1 commit into from Oct 31, 2021

Conversation

refractionpcsx2
Copy link
Member

Description of Changes

Fixes compatibility with old savestates + remove PRMODE which is no longer used. Also bumps savestate version.

Rationale behind Changes

Recent changes temporarily broke compat with older states since it was merged before the PR was completely ready.

Suggested Testing Steps

Test GS Dumps and savestates from PCSX2 to make sure they all work ok.

@github-actions github-actions bot added the GS label Oct 28, 2021
@lightningterror lightningterror added this to the Release 1.8 milestone Oct 28, 2021
@refractionpcsx2 refractionpcsx2 removed this from the Release 1.8 milestone Oct 28, 2021
@prafullpcsx2
Copy link
Contributor

Still getting this message with old gsdumpgui while trying to run freshly made gsdump:-

image

And still getting black screen with pcsx2 integrated gs debugger ( dev 1961 and older).

@refractionpcsx2
Copy link
Member Author

refractionpcsx2 commented Oct 30, 2021

Of course, you can't go backwards.. You get backwards compat from old versions with the new version, but you will never be able to make a new gs dump and run it on the old gsdumpgui. I'm afraid that's dead unless people use an old version of pcsx2

@prafullpcsx2
Copy link
Contributor

Thanks for explanation. That means we lose ability to check for regressions unless we are going to ask users to make gs dumps using old pcsx2 versions. I hope the gains are far more than this loss.

@refractionpcsx2
Copy link
Member Author

refractionpcsx2 commented Oct 30, 2021

Why can't you use the gsdump too in the new version?

Edit: nevermind, I know why, because of testing old GSDX versions. I think we're just gonna have to lump it so we can move forward, 1.6 will just need to be used if you need to regression test.

@refractionpcsx2 refractionpcsx2 merged commit 7888111 into master Oct 31, 2021
@refractionpcsx2 refractionpcsx2 deleted the gs_state branch October 31, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants