GS: Let draw happen even if invalid, log invalid draws #4965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
gs_ignoreinvalidz
branch
from
29bf3f1 to
baeff7f
Compare
refractionpcsx2
force-pushed
the
gs_ignoreinvalidz
branch
from
baeff7f to
192a1e3
Compare
refractionpcsx2
force-pushed
the
gs_ignoreinvalidz
branch
from
192a1e3 to
1fb6193
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Allow draws to happen regardless of frame/z format, log invalid draws that matter
Rationale behind Changes
Star Ocean 3 was setting the Z Buffer to an invalid storage format, but the Z was masked and there was no depth test, so its format was irrelevant. Previously the draw got skipped, but if the draw is wrong, it's going to be broken anyway.
Suggested Testing Steps
Test Star Ocean 3 battle transitions, uhh, not sure what else it'll affect, so just try random stuff to make sure it's okay I guess.
Fixes #4948