Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS: Let draw happen even if invalid, log invalid draws #4965

merged 1 commit into from
Oct 31, 2021


Copy link

Description of Changes

Allow draws to happen regardless of frame/z format, log invalid draws that matter

Rationale behind Changes

Star Ocean 3 was setting the Z Buffer to an invalid storage format, but the Z was masked and there was no depth test, so its format was irrelevant. Previously the draw got skipped, but if the draw is wrong, it's going to be broken anyway.

Suggested Testing Steps

Test Star Ocean 3 battle transitions, uhh, not sure what else it'll affect, so just try random stuff to make sure it's okay I guess.

Fixes #4948

Copy link

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@refractionpcsx2 refractionpcsx2 merged commit 0d946d8 into master Oct 31, 2021
@refractionpcsx2 refractionpcsx2 deleted the gs_ignoreinvalidz branch October 31, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Star Ocean battle transition effect broken with all renderers
2 participants