GS: Fix up CLUT offset handling in 32bit I8 mode #4966
Conversation
refractionpcsx2
force-pushed
the
gs_clutoffset
branch
6 times, most recently
from
83691b9 to
abe162f
Compare
|
Played GT3 for a good 2 hours with it. No visible issues. |
|
Yeah long awaited PR that's for sure, and it does work fine in the games which did have problems with CLUT. I tested Spiderman Friend or Foe but you can expect a bunch of Activion games such as Cabela to be fixed as well. The only remaining gremlin is Virtual-On but well, not related isn't it? |
|
Virtual-On is an invalidation issue, like other Sega games I believe it draws to the CLUT and should invalidate it, but it doesn't, I need to look in to it. Forcefully invalidating it makes the game work. |
|
I was waiting for this since a long time. It fixes a large number of games (including all broken cabela games as well as ROTK series). Here are few before and after comparison screenshots. Harley Davidson – Race to Rally
Romance of Three Kingdoms VII
Spiderman Friend or Foe
Cabela’s Dangerous Hunts 2
NPPL Championship Paintball 2009
History Channel: Battle for the Pacific
Grand Theft Auto San Andreas
Rapala Pro Bass Fishing
Romance of Three Kingdoms VIII
Cabela’s Legendary Adventures
Shamu’s Deep Sea Adventures
Cabela’s Big Game Hunter 2005 Adventures
|
refractionpcsx2
force-pushed
the
gs_clutoffset
branch
from
abe162f to
7687c24
Compare
refractionpcsx2
force-pushed
the
gs_clutoffset
branch
from
7687c24 to
3991b2f
Compare
|
Updated GTA pictures Before:
After:
|
ghost
mentioned this pull request
Description of Changes
Fixes CLUT writing for games which use an offset to write to sections of the CLUT in PSMCT32 mode with I8. Wraps CLUT memory when reading with an offset
Rationale behind Changes
Writing with offset was broken and previously used the "clut_reload_on_draw" hack, which wasn't really the solution. Also remove CLUT memory wrapping code (by duplicating it) didn't really work, so now it properly wraps.
Suggested Testing Steps
Test games mentioned, make sure the colours are correct. Test other games just to make sure nothing is broken.
Games which previously needed the load_clut_before_draw hack
Cabela's Hunting games
Harley Davidson
Fixes #1597
Also fixes Romance of the Three Kingdoms games colours.
Fixes #1628
Fixes #2390
The History Channel: Battle for the Pacific
Fixes #4396
Other games apparently fixed
NPPL Championship Paintball 2009
Spider-Man Friend or Foe
Apparently fixes Rapala Pro Fishing also
Correctly clamping of CLUT reading with offset to repeat last CSA offset fixes GTA San Andreas dirt
Fixes #2650