GHActions: Don't shallow clone submodules#4982
Merged
Merged
Conversation
Member
Author
|
We can also do this by removing the shallow mark from |
lightningterror
approved these changes
Nov 12, 2021
TellowKrinkle
force-pushed
the
noshallow
branch
from
November 13, 2021 01:38
e750c72 to
2d326c4
Compare
Shallow clones tend to be 5-10s slower
TellowKrinkle
force-pushed
the
noshallow
branch
from
November 13, 2021 01:39
2d326c4 to
dca18ce
Compare
xTVaser
approved these changes
Nov 21, 2021
xTVaser
left a comment
Member
There was a problem hiding this comment.
this is really counter-intuitive. Everything i read suggests that shallow clones are intuitively the right choice for temp CI builds, but also faster. But I can't argue with the graphs :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Shallow clones tend to be 5-10s slower
GHActions Windows submodule checkout run time (seconds):

Linux:

macOS (never used GH cache on submodules):

Rationale behind Changes
Why waste 10 seconds when you don't have to?
Suggested Testing Steps
Watch the CI run