Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHActions: Don't shallow clone submodules #4982

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

TellowKrinkle
Copy link
Member

Description of Changes

Shallow clones tend to be 5-10s slower

GHActions Windows submodule checkout run time (seconds):
image

Linux:
image

macOS (never used GH cache on submodules):
image

Rationale behind Changes

Why waste 10 seconds when you don't have to?

Suggested Testing Steps

Watch the CI run

@TellowKrinkle
Copy link
Member Author

We can also do this by removing the shallow mark from .gitmodules, depending on whether we want to change the default for non-CI users checking out the repo. Preferences?

Shallow clones tend to be 5-10s slower
@github-actions github-actions bot added Dependencies Pull requests that update a dependency file and removed Build | Project System labels Nov 13, 2021
Copy link
Sponsor Member

@xTVaser xTVaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really counter-intuitive. Everything i read suggests that shallow clones are intuitively the right choice for temp CI builds, but also faster. But I can't argue with the graphs :/

@TellowKrinkle TellowKrinkle merged commit 01855fc into PCSX2:master Nov 24, 2021
@TellowKrinkle TellowKrinkle deleted the noshallow branch November 24, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants