wx: Fix pxExplore on macOS
#4989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to open file urls in a browser does not actually launch a file explorer in macOS
|
pxExplore is only ever used once. Couldn't we just get rid of it, and change that line of code? |
Was barely used
|
Clicked browse in several places under Linux and it came up with a file browser in the right folders. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Makes
pxExplorework correctly on macOSRationale behind Changes
It didn't work
Suggested Testing Steps
Make sure you can still use the "Open in Explorer" buttons in the settings window
I would think
wxLaunchDefaultApplicationwill work at least as well as the old solution on all platforms but who knows