Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wx: Fix pxExplore on macOS #4989

Merged
merged 2 commits into from
Nov 20, 2021
Merged

wx: Fix pxExplore on macOS #4989

merged 2 commits into from
Nov 20, 2021

Conversation

TellowKrinkle
Copy link
Member

Description of Changes

Makes pxExplore work correctly on macOS

Rationale behind Changes

It didn't work

Suggested Testing Steps

Make sure you can still use the "Open in Explorer" buttons in the settings window

I would think wxLaunchDefaultApplication will work at least as well as the old solution on all platforms but who knows

Trying to open file urls in a browser does not actually launch a file explorer in macOS
@github-actions github-actions bot added the GUI/WX label Nov 6, 2021
@arcum42
Copy link
Contributor

arcum42 commented Nov 7, 2021

pxExplore is only ever used once. Couldn't we just get rid of it, and change that line of code?

@arcum42
Copy link
Contributor

arcum42 commented Nov 12, 2021

Clicked browse in several places under Linux and it came up with a file browser in the right folders.

@arcum42 arcum42 merged commit 9c0582a into master Nov 20, 2021
@lightningterror lightningterror deleted the pxexplore-fix branch November 20, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants