Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Always default CMAKE_BUILD_PO off #4999

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

TellowKrinkle
Copy link
Member

Description of Changes

Defaults the CMAKE_BUILD_PO option to off for all build modes

Rationale behind Changes

Git files getting modified by build is just as much of a pain in release builds as it is in devel builds

Suggested Testing Steps

Build in release and see if it modifies files tracked by git

Git files getting modified by build is just as much of a pain in release builds as it is in devel builds
Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on Linux.

@TellowKrinkle TellowKrinkle merged commit 3408749 into PCSX2:master Nov 26, 2021
@TellowKrinkle TellowKrinkle deleted the no-build-po branch November 26, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants